refactor(forms): remove unnecessary Array.from (#50314)

garrettld · AndrewKushnir · commit efa92ab6caf6 · 2023-05-16T09:25:26.000-07:00
The Array.from isn't necessary since we're just iterating over the map keys. PR Close #50314
diff --git a/packages/forms/src/directives/select_control_value_accessor.ts b/packages/forms/src/directives/select_control_value_accessor.ts
@@ -147,7 +147,7 @@ export class SelectControlValueAccessor extends BuiltInControlValueAccessor impl
 
   /** @internal */
   _getOptionId(value: any): string|null {
-    for (const id of Array.from(this._optionMap.keys())) {
+    for (const id of this._optionMap.keys()) {
       if (this._compareWith(this._optionMap.get(id), value)) return id;
     }
     return null;
diff --git a/packages/forms/src/directives/select_multiple_control_value_accessor.ts b/packages/forms/src/directives/select_multiple_control_value_accessor.ts
@@ -179,7 +179,7 @@ export class SelectMultipleControlValueAccessor extends BuiltInControlValueAcces
 
   /** @internal */
   _getOptionId(value: any): string|null {
-    for (const id of Array.from(this._optionMap.keys())) {
+    for (const id of this._optionMap.keys()) {
       if (this._compareWith(this._optionMap.get(id)!._value, value)) return id;
     }
     return null;

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ export class SelectControlValueAccessor extends BuiltInControlValueAccessor impl`
`147`	`147`
`148`	`148`	`/** @internal */`
`149`	`149`	`_getOptionId(value: any): string\|null {`
`150`		`- for (const id of Array.from(this._optionMap.keys())) {`
	`150`	`+ for (const id of this._optionMap.keys()) {`
`151`	`151`	`if (this._compareWith(this._optionMap.get(id), value)) return id;`
`152`	`152`	`}`
`153`	`153`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ export class SelectMultipleControlValueAccessor extends BuiltInControlValueAcces`
`179`	`179`
`180`	`180`	`/** @internal */`
`181`	`181`	`_getOptionId(value: any): string\|null {`
`182`		`- for (const id of Array.from(this._optionMap.keys())) {`
	`182`	`+ for (const id of this._optionMap.keys()) {`
`183`	`183`	`if (this._compareWith(this._optionMap.get(id)!._value, value)) return id;`
`184`	`184`	`}`
`185`	`185`	`return null;`