Revert "fix(platform-browser): KeyEventsPlugin should keep the same behavior (#49330)" (#49357)

thePunderWoman · thePunderWoman · commit ed2397493135 · 2023-03-07T17:51:04.000Z
This reverts commit 2312eb5. PR Close #49357
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -611,6 +611,9 @@
   {
     "name": "getCurrentTNodePlaceholderOk"
   },
+  {
+    "name": "getDOM"
+  },
   {
     "name": "getDeclarationTNode"
   },
diff --git a/packages/platform-browser/src/dom/events/key_events.ts b/packages/platform-browser/src/dom/events/key_events.ts
@@ -78,9 +78,12 @@ export class KeyEventsPlugin extends EventManagerPlugin {
   override addEventListener(element: HTMLElement, eventName: string, handler: Function): Function {
     const parsedEvent = KeyEventsPlugin.parseEventName(eventName)!;
 
-    const outsideHandler = KeyEventsPlugin.eventCallback(parsedEvent['fullKey'], handler);
+    const outsideHandler =
+        KeyEventsPlugin.eventCallback(parsedEvent['fullKey'], handler, this.manager.getZone());
 
-    return this.manager.addEventListener(element, parsedEvent['domEventName'], outsideHandler);
+    return this.manager.getZone().runOutsideAngular(() => {
+      return getDOM().onAndCancel(element, parsedEvent['domEventName'], outsideHandler);
+    });
   }
 
   /**
@@ -175,10 +178,10 @@ export class KeyEventsPlugin extends EventManagerPlugin {
    * @param zone The zone in which the event occurred.
    * @returns A callback function.
    */
-  static eventCallback(fullKey: string, handler: Function): Function {
+  static eventCallback(fullKey: string, handler: Function, zone: NgZone): Function {
     return (event: KeyboardEvent) => {
       if (KeyEventsPlugin.matchEventFullKeyCode(event, fullKey)) {
-        handler(event);
+        zone.runGuarded(() => handler(event));
       }
     };
   }

Original file line number	Diff line number	Diff line change
`@@ -611,6 +611,9 @@`
`611`	`611`	`{`
`612`	`612`	`"name": "getCurrentTNodePlaceholderOk"`
`613`	`613`	`},`
	`614`	`+ {`
	`615`	`+ "name": "getDOM"`
	`616`	`+ },`
`614`	`617`	`{`
`615`	`618`	`"name": "getDeclarationTNode"`
`616`	`619`	`},`