Skip to content

Commit d5565cc

Browse files
JiaLiPassionalxhub
authored andcommitted
fix(zone.js): fix several test cases which trigger done() multiple times (#45025)
Several test cases trigger the `done()` multiple times and cause warning from jasmine. This commit fixes these test cases. PR Close #45025
1 parent dea7234 commit d5565cc

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

packages/zone.js/test/browser/XMLHttpRequest.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,14 +336,16 @@ describe('XMLHttpRequest', function() {
336336
const req = new XMLHttpRequest();
337337
req.open('get', '/', true);
338338
req.send();
339-
req.addEventListener('readystatechange', function(ev) {
339+
const listener = function(ev: any) {
340340
if (req.readyState >= 2) {
341341
expect(() => {
342342
req.abort();
343343
}).not.toThrow();
344+
req.removeEventListener('readystatechange', listener);
344345
done();
345346
}
346-
});
347+
};
348+
req.addEventListener('readystatechange', listener);
347349
});
348350
});
349351

packages/zone.js/test/browser/browser.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2907,6 +2907,7 @@ describe('Zone', function() {
29072907

29082908
expect(entries.length).toBe(1);
29092909
expect(entries[0].target).toBe(div);
2910+
observer.disconnect();
29102911
done();
29112912
});
29122913

packages/zone.js/test/extra/cordova.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ describe('cordova test', () => {
1919
cordova.exec(
2020
() => {
2121
expect(Zone.current.name).toEqual('cordova');
22-
done();
2322
},
2423
() => {
2524
fail('should not fail');

0 commit comments

Comments
 (0)