Skip to content

Commit b44f7b5

Browse files
JiaLiPassionalxhub
authored andcommitted
fix(zone.js): fix 2 bluebird test cases for each/mapSeries (#36295)
`Bluebird.each` and `Bluebird.mapSeries` will accept a callback with `value` parameter, the `value` should be the item in the array, not array itself. For example: ``` const arr = [1, 2]; Bluebird.each(arr, function(value, idx) { console.log(`value: ${value}, idx: ${idx}`); }) ``` the output will be ``` value: 1, idx: 0 value: 2, idx: 1 ``` This PR fix the test cases for `each` and `mapSeries` APIs. PR Close #36295
1 parent c5df9ce commit b44f7b5

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/zone.js/test/extra/bluebird.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,8 @@ describe('bluebird promise', () => {
283283
BluebirdPromise
284284
.each(
285285
BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)),
286-
(r: number[], idx: number) => {
287-
expect(r[idx] === arr[idx]);
286+
(r: number, idx: number) => {
287+
expect(r).toBe(arr[idx]);
288288
expect(Zone.current.name).toEqual('bluebird');
289289
})
290290
.then((r: any) => {
@@ -304,8 +304,8 @@ describe('bluebird promise', () => {
304304
BluebirdPromise
305305
.mapSeries(
306306
BluebirdPromise.map(arr, (item: number) => BluebirdPromise.resolve(item)),
307-
(r: number[], idx: number) => {
308-
expect(r[idx] === arr[idx]);
307+
(r: number, idx: number) => {
308+
expect(r).toBe(arr[idx]);
309309
expect(Zone.current.name).toEqual('bluebird');
310310
})
311311
.then((r: any) => {

0 commit comments

Comments
 (0)