fix(common): add right ContentType for boolean values with HttpClient request body(#38924) (#41885)

gopal-jayaraman · mhevery · commit 922a60283183 · 2021-05-03T10:00:19.000-07:00
currently a boolean as body is seen as text/plain, where is should be seen as application/json, since it is valid JSON, like numbers. PR Close #41885
diff --git a/packages/common/http/src/request.ts b/packages/common/http/src/request.ts
@@ -322,9 +322,9 @@ export class HttpRequest<T> {
     if (this.body instanceof HttpParams) {
       return 'application/x-www-form-urlencoded;charset=UTF-8';
     }
-    // Arrays, objects, and numbers will be encoded as JSON.
+    // Arrays, objects, boolean and numbers will be encoded as JSON.
     if (typeof this.body === 'object' || typeof this.body === 'number' ||
-        Array.isArray(this.body)) {
+        typeof this.body === 'boolean') {
       return 'application/json';
     }
     // No type could be inferred.
diff --git a/packages/common/http/test/request_spec.ts b/packages/common/http/test/request_spec.ts
@@ -129,6 +129,10 @@ const TEST_STRING = `I'm a body!`;
         const req = baseReq.clone({body: {data: 'test data'}});
         expect(req.detectContentTypeHeader()).toBe('application/json');
       });
+      it('handles boolean as json', () => {
+        const req = baseReq.clone({body: true});
+        expect(req.detectContentTypeHeader()).toBe('application/json');
+      });
     });
     describe('body serialization', () => {
       const baseReq = new HttpRequest('POST', '/test', null);

Original file line number	Diff line number	Diff line change
`@@ -322,9 +322,9 @@ export class HttpRequest<T> {`
`322`	`322`	`if (this.body instanceof HttpParams) {`
`323`	`323`	`return 'application/x-www-form-urlencoded;charset=UTF-8';`
`324`	`324`	`}`
`325`		`- // Arrays, objects, and numbers will be encoded as JSON.`
	`325`	`+ // Arrays, objects, boolean and numbers will be encoded as JSON.`
`326`	`326`	`if (typeof this.body === 'object' \|\| typeof this.body === 'number' \|\|`
`327`		`- Array.isArray(this.body)) {`
	`327`	`+ typeof this.body === 'boolean') {`
`328`	`328`	`return 'application/json';`
`329`	`329`	`}`
`330`	`330`	`// No type could be inferred.`