fix(core): catch errors from source signals outside of .next (#49769)

atscott · AndrewKushnir · commit 84216dabfcfc · 2023-04-12T09:35:56.000-07:00
From Ben: > When dealing with any reactive function call you don't control > like `observer.next()` (or anything similar), you want to catch the error > in the producer call, in this case `signal()`. You don't want to catch errors > in the `observer.next` call itself. PR Close #49769
diff --git a/packages/core/rxjs-interop/src/to_observable.ts b/packages/core/rxjs-interop/src/to_observable.ts
@@ -43,11 +43,14 @@ export function toObservable<T>(
   // references to `source` to be dropped if the `Observable` is fully unsubscribed and thrown away.
   return new Observable(observer => {
     const watcher = effect(() => {
+      let value: T;
       try {
-        observer.next(source());
+        value = source();
       } catch (err) {
         observer.error(err);
+        return;
       }
+      observer.next(value);
     }, {injector, manualCleanup: true});
     return () => watcher.destroy();
   });
