perf(core): make Compiler, ApplicationRef and ApplicationInitStatus tree-shakable (#45102) (#45222)

AndrewKushnir · thePunderWoman · commit 82d772857ce2 · 2022-03-01T18:38:17.000Z
The `Compiler`, `ApplicationRef` and `ApplicationInitStatus` classes are registered as non-tree-shakable providers in the `ApplicationModule`. This commit converts them to the tree-shakable providers instead. PR Close #45102 PR Close #45222
diff --git a/packages/core/src/application_init.ts b/packages/core/src/application_init.ts
@@ -91,7 +91,7 @@ export const APP_INITIALIZER =
  *
  * @publicApi
  */
-@Injectable()
+@Injectable({providedIn: 'root'})
 export class ApplicationInitStatus {
   private resolve = noop;
   private reject = noop;
diff --git a/packages/core/src/application_module.ts b/packages/core/src/application_module.ts
@@ -6,18 +6,13 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {APP_INITIALIZER, ApplicationInitStatus} from './application_init';
 import {ApplicationRef} from './application_ref';
 import {APP_ID_RANDOM_PROVIDER} from './application_tokens';
-import {Injector, StaticProvider} from './di';
+import {StaticProvider} from './di';
 import {Inject, Optional, SkipSelf} from './di/metadata';
-import {ErrorHandler} from './error_handler';
 import {DEFAULT_LOCALE_ID, USD_CURRENCY_CODE} from './i18n/localization';
 import {DEFAULT_CURRENCY_CODE, LOCALE_ID} from './i18n/tokens';
-import {ComponentFactoryResolver} from './linker';
-import {Compiler} from './linker/compiler';
 import {NgModule} from './metadata';
-import {NgZone} from './zone';
 
 declare const $localize: {locale?: string};
 
@@ -56,17 +51,6 @@ export function getGlobalLocale(): string {
  * that is used to configure the root injector for bootstrapping.
  */
 export const APPLICATION_MODULE_PROVIDERS: StaticProvider[] = [
-  {
-    provide: ApplicationRef,
-    useClass: ApplicationRef,
-    deps: [NgZone, Injector, ErrorHandler, ComponentFactoryResolver, ApplicationInitStatus]
-  },
-  {
-    provide: ApplicationInitStatus,
-    useClass: ApplicationInitStatus,
-    deps: [[new Optional(), APP_INITIALIZER]]
-  },
-  {provide: Compiler, useClass: Compiler, deps: []},
   APP_ID_RANDOM_PROVIDER,
   {
     provide: LOCALE_ID,
diff --git a/packages/core/src/application_ref.ts b/packages/core/src/application_ref.ts
@@ -564,7 +564,7 @@ function optionsReducer<T extends Object>(dst: any, objs: T|T[]): T {
  *
  * @publicApi
  */
-@Injectable()
+@Injectable({providedIn: 'root'})
 export class ApplicationRef {
   /** @internal */
   private _bootstrapListeners: ((compRef: ComponentRef<any>) => void)[] = [];
diff --git a/packages/core/src/linker/compiler.ts b/packages/core/src/linker/compiler.ts
@@ -52,7 +52,7 @@ export class ModuleWithComponentFactories<T> {
  * See [JIT API changes due to ViewEngine deprecation](guide/deprecations#jit-api-changes) for
  * additional context.
  */
-@Injectable()
+@Injectable({providedIn: 'root'})
 export class Compiler {
   /**
    * Compiles the given NgModule and all of its components. All templates of the components listed
diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -122,9 +122,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -347,9 +344,6 @@
   {
     "name": "NgLocalization"
   },
-  {
-    "name": "NgModuleFactory2"
-  },
   {
     "name": "NgModuleRef"
   },
@@ -422,9 +416,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SELF_TOKEN_REGEX"
   },
@@ -677,6 +668,9 @@
   {
     "name": "collectNativeNodes"
   },
+  {
+    "name": "compileNgModuleFactory"
+  },
   {
     "name": "computeStaticStyling"
   },
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -86,9 +86,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -437,9 +434,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SERVER_TRANSITION_PROVIDERS"
   },
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -92,9 +92,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -431,9 +428,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SERVER_TRANSITION_PROVIDERS"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -578,9 +578,6 @@
   {
     "name": "SAFE_URL_PATTERN"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SEGMENT_RE"
   },

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ export const APP_INITIALIZER =`
`91`	`91`	`*`
`92`	`92`	`* @publicApi`
`93`	`93`	`*/`
`94`		`-@Injectable()`
	`94`	`+@Injectable({providedIn: 'root'})`
`95`	`95`	`export class ApplicationInitStatus {`
`96`	`96`	`private resolve = noop;`
`97`	`97`	`private reject = noop;`
Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,7 @@ function optionsReducer<T extends Object>(dst: any, objs: T\|T[]): T {`
`564`	`564`	`*`
`565`	`565`	`* @publicApi`
`566`	`566`	`*/`
`567`		`-@Injectable()`
	`567`	`+@Injectable({providedIn: 'root'})`
`568`	`568`	`export class ApplicationRef {`
`569`	`569`	`/** @internal */`
`570`	`570`	`private _bootstrapListeners: ((compRef: ComponentRef<any>) => void)[] = [];`
Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,6 @@`
`122`	`122`	`{`
`123`	`123`	`"name": "CommonModule"`
`124`	`124`	`},`
`125`		`- {`
`126`		`- "name": "Compiler"`
`127`		`- },`
`128`	`125`	`{`
`129`	`126`	`"name": "ComponentFactory"`
`130`	`127`	`},`
`@@ -347,9 +344,6 @@`
`347`	`344`	`{`
`348`	`345`	`"name": "NgLocalization"`
`349`	`346`	`},`
`350`		`- {`
`351`		`- "name": "NgModuleFactory2"`
`352`		`- },`
`353`	`347`	`{`
`354`	`348`	`"name": "NgModuleRef"`
`355`	`349`	`},`
`@@ -422,9 +416,6 @@`
`422`	`416`	`{`
`423`	`417`	`"name": "RuntimeError"`
`424`	`418`	`},`
`425`		`- {`
`426`		`- "name": "SCHEDULER"`
`427`		`- },`
`428`	`419`	`{`
`429`	`420`	`"name": "SELF_TOKEN_REGEX"`
`430`	`421`	`},`
`@@ -677,6 +668,9 @@`
`677`	`668`	`{`
`678`	`669`	`"name": "collectNativeNodes"`
`679`	`670`	`},`
	`671`	`+ {`
	`672`	`+ "name": "compileNgModuleFactory"`
	`673`	`+ },`
`680`	`674`	`{`
`681`	`675`	`"name": "computeStaticStyling"`
`682`	`676`	`},`
Original file line number	Diff line number	Diff line change
`@@ -86,9 +86,6 @@`
`86`	`86`	`{`
`87`	`87`	`"name": "CommonModule"`
`88`	`88`	`},`
`89`		`- {`
`90`		`- "name": "Compiler"`
`91`		`- },`
`92`	`89`	`{`
`93`	`90`	`"name": "ComponentFactory"`
`94`	`91`	`},`
`@@ -437,9 +434,6 @@`
`437`	`434`	`{`
`438`	`435`	`"name": "RuntimeError"`
`439`	`436`	`},`
`440`		`- {`
`441`		`- "name": "SCHEDULER"`
`442`		`- },`
`443`	`437`	`{`
`444`	`438`	`"name": "SERVER_TRANSITION_PROVIDERS"`
`445`	`439`	`},`
Original file line number	Diff line number	Diff line change
`@@ -92,9 +92,6 @@`
`92`	`92`	`{`
`93`	`93`	`"name": "CommonModule"`
`94`	`94`	`},`
`95`		`- {`
`96`		`- "name": "Compiler"`
`97`		`- },`
`98`	`95`	`{`
`99`	`96`	`"name": "ComponentFactory"`
`100`	`97`	`},`
`@@ -431,9 +428,6 @@`
`431`	`428`	`{`
`432`	`429`	`"name": "RuntimeError"`
`433`	`430`	`},`
`434`		`- {`
`435`		`- "name": "SCHEDULER"`
`436`		`- },`
`437`	`431`	`{`
`438`	`432`	`"name": "SERVER_TRANSITION_PROVIDERS"`
`439`	`433`	`},`
Original file line number	Diff line number	Diff line change
`@@ -578,9 +578,6 @@`
`578`	`578`	`{`
`579`	`579`	`"name": "SAFE_URL_PATTERN"`
`580`	`580`	`},`
`581`		`- {`
`582`		`- "name": "SCHEDULER"`
`583`		`- },`
`584`	`581`	`{`
`585`	`582`	`"name": "SEGMENT_RE"`
`586`	`583`	`},`