fix(language-service): use script versions for incremental compilations (#41475)

alxhub · zarend · commit 78236bfdcaeb · 2021-04-13T13:05:36.000-07:00
This commit has the Language Service take advantage of versioned source files added in the compiler previously. With this change, the Language Service's incremental compilations will now be correct even if the TS Language service mutates `ts.SourceFile`s without changing their object identity, as we know it does in certain corner cases. No test is added here as it is difficult to reproduce this behavior in the LS's artificial testing environment. A test for this case exists in the LS extension repo, where it will be used to validate that a workaround three is no longer necessary. PR Close #41475
diff --git a/packages/language-service/ivy/language_service.ts b/packages/language-service/ivy/language_service.ts
@@ -487,6 +487,9 @@ function createProgramDriver(project: ts.server.Project): ProgramDriver {
         scriptInfo.editContent(0, length, newText);
       }
     },
+    getSourceFileVersion(sf: ts.SourceFile): string {
+      return project.getScriptVersion(sf.fileName);
+    }
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -487,6 +487,9 @@ function createProgramDriver(project: ts.server.Project): ProgramDriver {`
`487`	`487`	`scriptInfo.editContent(0, length, newText);`
`488`	`488`	`}`
`489`	`489`	`},`
	`490`	`+ getSourceFileVersion(sf: ts.SourceFile): string {`
	`491`	`+ return project.getScriptVersion(sf.fileName);`
	`492`	`+ }`
`490`	`493`	`};`
`491`	`494`	`}`
`492`	`495`