refactor(core): remove webworker related checks on assertDomNode (#50061)

JeanMeche · alxhub · commit 73fcf9f20bbe · 2023-05-08T14:30:39.000-07:00
Since the drop of the webworker platform the node can't be a `WebWorkerRenderNode`. PR Close #50061
diff --git a/packages/core/src/util/assert.ts b/packages/core/src/util/assert.ts
@@ -107,15 +107,11 @@ export function throwError(msg: string, actual?: any, expected?: any, comparison
 }
 
 export function assertDomNode(node: any): asserts node is Node {
-  // If we're in a worker, `Node` will not be defined.
-  if (!(typeof Node !== 'undefined' && node instanceof Node) &&
-      !(typeof node === 'object' && node != null &&
-        node.constructor.name === 'WebWorkerRenderNode')) {
+  if (!(node instanceof Node)) {
     throwError(`The provided value must be an instance of a DOM Node but got ${stringify(node)}`);
   }
 }
 
-
 export function assertIndexInRange(arr: any[], index: number) {
   assertDefined(arr, 'Array must be defined.');
   const maxLen = arr.length;
@@ -124,7 +120,6 @@ export function assertIndexInRange(arr: any[], index: number) {
   }
 }
 
-
 export function assertOneOf(value: any, ...validValues: any[]) {
   if (validValues.indexOf(value) !== -1) return true;
   throwError(`Expected value to be one of ${JSON.stringify(validValues)} but was ${

Original file line number	Diff line number	Diff line change
`@@ -107,15 +107,11 @@ export function throwError(msg: string, actual?: any, expected?: any, comparison`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`export function assertDomNode(node: any): asserts node is Node {`
`110`		- // If we're in a worker, `Node` will not be defined.
`111`		`- if (!(typeof Node !== 'undefined' && node instanceof Node) &&`
`112`		`- !(typeof node === 'object' && node != null &&`
`113`		`- node.constructor.name === 'WebWorkerRenderNode')) {`
	`110`	`+ if (!(node instanceof Node)) {`
`114`	`111`	throwError(`The provided value must be an instance of a DOM Node but got ${stringify(node)}`);
`115`	`112`	`}`
`116`	`113`	`}`
`117`	`114`
`118`		`-`
`119`	`115`	`export function assertIndexInRange(arr: any[], index: number) {`
`120`	`116`	`assertDefined(arr, 'Array must be defined.');`
`121`	`117`	`const maxLen = arr.length;`
`@@ -124,7 +120,6 @@ export function assertIndexInRange(arr: any[], index: number) {`
`124`	`120`	`}`
`125`	`121`	`}`
`126`	`122`
`127`		`-`
`128`	`123`	`export function assertOneOf(value: any, ...validValues: any[]) {`
`129`	`124`	`if (validValues.indexOf(value) !== -1) return true;`
`130`	`125`	throwError(`Expected value to be one of ${JSON.stringify(validValues)} but was ${