Commit 72e6a94
The `Observable` chain is currenlty the most straightforward way to
handle navigation cancellations where we ensure that the cancelled
navigation does not continue to be processed. Until we design and
implement an alternative way to accomplish equivalent functionality,
we need to maintain the `Observable` chain wherever we might execute
user code. One reason for this isthat user code may contain redirects so we do not
want to execute those redirects if the navigation was already cancelled.
PR Close #46021
1 parent de058bb commit 72e6a94
6 files changed
Lines changed: 241 additions & 160 deletions
File tree
- goldens
- circular-deps
- size-tracking
- packages
- core/test/bundling/router
- router
- src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
305 | 305 | | |
306 | 306 | | |
307 | 307 | | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
308 | 314 | | |
309 | 315 | | |
310 | 316 | | |
| |||
326 | 332 | | |
327 | 333 | | |
328 | 334 | | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | 335 | | |
334 | 336 | | |
335 | 337 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
Lines changed: 16 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
494 | 494 | | |
495 | 495 | | |
496 | 496 | | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
497 | 500 | | |
498 | 501 | | |
499 | 502 | | |
| |||
674 | 677 | | |
675 | 678 | | |
676 | 679 | | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
677 | 683 | | |
678 | 684 | | |
679 | 685 | | |
| |||
1520 | 1526 | | |
1521 | 1527 | | |
1522 | 1528 | | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
1523 | 1532 | | |
1524 | 1533 | | |
1525 | 1534 | | |
| |||
1562 | 1571 | | |
1563 | 1572 | | |
1564 | 1573 | | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
1565 | 1577 | | |
1566 | 1578 | | |
1567 | 1579 | | |
| |||
1604 | 1616 | | |
1605 | 1617 | | |
1606 | 1618 | | |
1607 | | - | |
1608 | | - | |
1609 | | - | |
1610 | 1619 | | |
1611 | 1620 | | |
1612 | 1621 | | |
| |||
1667 | 1676 | | |
1668 | 1677 | | |
1669 | 1678 | | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
1670 | 1682 | | |
1671 | 1683 | | |
1672 | 1684 | | |
| |||
1695 | 1707 | | |
1696 | 1708 | | |
1697 | 1709 | | |
1698 | | - | |
| 1710 | + | |
1699 | 1711 | | |
1700 | 1712 | | |
1701 | 1713 | | |
| |||
0 commit comments