feat(zone.js): include zone name when sync-test zone reports tasks

devversion · devversion · commit 72c2567847c3 · 2022-07-18T19:19:00.000+02:00
The sync-test zone is used in e.g. `describe` to raise an error when
there is asynchronous code scheduled in describe blocks. This commit
includes the zone name in such thrown errors to allow for us to include
the jasmine describe name in the error. This will be wired up in the
jasmine zonejs patches separately.
diff --git a/packages/zone.js/lib/zone-spec/sync-test.ts b/packages/zone.js/lib/zone-spec/sync-test.ts
@@ -21,7 +21,7 @@ class SyncTestZoneSpec implements ZoneSpec {
     switch (task.type) {
       case 'microTask':
       case 'macroTask':
-        throw new Error(`Cannot call ${task.source} from within a sync test.`);
+        throw new Error(`Cannot call ${task.source} from within a sync test (${this.name}).`);
       case 'eventTask':
         task = delegate.scheduleTask(target, task);
         break;
diff --git a/packages/zone.js/test/zone-spec/sync-test.spec.ts b/packages/zone.js/test/zone-spec/sync-test.spec.ts
@@ -22,15 +22,19 @@ describe('SyncTestZoneSpec', () => {
     syncTestZone.run(() => {
       expect(() => {
         Promise.resolve().then(function() {});
-      }).toThrow(new Error('Cannot call Promise.then from within a sync test.'));
+      })
+          .toThrow(new Error(
+              'Cannot call Promise.then from within a sync test (syncTestZone for name).'));
     });
   });
 
   it('should fail on setTimeout', () => {
     syncTestZone.run(() => {
       expect(() => {
         setTimeout(() => {}, 100);
-      }).toThrow(new Error('Cannot call setTimeout from within a sync test.'));
+      })
+          .toThrow(
+              new Error('Cannot call setTimeout from within a sync test (syncTestZone for name).'));
     });
   });
 
