fix(zone.js): __load_patch and __symbol__ should be in zone_extern for closure compiler (#31350)

JiaLiPassion · mhevery · commit 6b51ed29efc5 · 2019-07-24T13:30:01.000-07:00
PR Close #31350
diff --git a/packages/zone.js/lib/closure/zone_externs.js b/packages/zone.js/lib/closure/zone_externs.js
@@ -27,6 +27,10 @@ Zone.prototype.name;
 
 Zone.assertZonePatched = function() {};
 
+Zone.__symbol__ = function(name) {};
+
+Zone.__load_patch = function(name, fn) {};
+
 /**
  * @type {!Zone} Returns the current [Zone]. Returns the current zone. The only way to change
  * the current zone is by invoking a run() method, which will update the current zone for the
diff --git a/packages/zone.js/lib/zone.ts b/packages/zone.js/lib/zone.ts
@@ -309,10 +309,15 @@ interface ZoneType {
    */
   root: Zone;
 
-  /** @internal */
+  /**
+  * load patch for specified native module, allow user to
+  * define their own patch, user can use this API after loading zone.js
+  */
   __load_patch(name: string, fn: _PatchFn): void;
 
-  /** Was @ internal but this prevents compiling tests as separate unit */
+  /**
+   * Zone symbol API to generate a string with __zone_symbol__ prefix
+   */
   __symbol__(name: string): string;
 }
 
diff --git a/packages/zone.js/test/closure/zone.closure.ts b/packages/zone.js/test/closure/zone.closure.ts
@@ -52,6 +52,9 @@ const testClosureFunction = () => {
     }
   };
 
+  Zone.__load_patch('test_closure_load_patch', function() {});
+  Zone.__symbol__('test_symbol');
+
   const testZone: Zone = Zone.current.fork(testZoneSpec);
   testZone.runGuarded(() => {
     testZone.run(() => {

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,9 @@ const testClosureFunction = () => {`
`52`	`52`	`}`
`53`	`53`	`};`
`54`	`54`
	`55`	`+ Zone.__load_patch('test_closure_load_patch', function() {});`
	`56`	`+ Zone.__symbol__('test_symbol');`
	`57`	`+`
`55`	`58`	`const testZone: Zone = Zone.current.fork(testZoneSpec);`
`56`	`59`	`testZone.runGuarded(() => {`
`57`	`60`	`testZone.run(() => {`