fix(core): ErrorHandler should not rethrow an error by default (#15077)

Dzmitry Shylovich · chuckjaz · commit 6559425b0729 · 2017-03-13T11:27:01.000-07:00
diff --git a/packages/core/src/error_handler.ts b/packages/core/src/error_handler.ts
@@ -46,7 +46,7 @@ export class ErrorHandler {
    */
   rethrowError: boolean;
 
-  constructor(rethrowError: boolean = true) { this.rethrowError = rethrowError; }
+  constructor(rethrowError: boolean = false) { this.rethrowError = rethrowError; }
 
   handleError(error: any): void {
     this._console.error(`EXCEPTION: ${this._extractMessage(error)}`);
@@ -71,8 +71,6 @@ export class ErrorHandler {
       }
     }
 
-    // We rethrow exceptions, so operations like 'bootstrap' will result in an error
-    // when an error happens. If we do not rethrow, bootstrap will always succeed.
     if (this.rethrowError) throw error;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export class ErrorHandler {`
`46`	`46`	`*/`
`47`	`47`	`rethrowError: boolean;`
`48`	`48`
`49`		`- constructor(rethrowError: boolean = true) { this.rethrowError = rethrowError; }`
	`49`	`+ constructor(rethrowError: boolean = false) { this.rethrowError = rethrowError; }`
`50`	`50`
`51`	`51`	`handleError(error: any): void {`
`52`	`52`	this._console.error(`EXCEPTION: ${this._extractMessage(error)}`);
`@@ -71,8 +71,6 @@ export class ErrorHandler {`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`
`74`		`- // We rethrow exceptions, so operations like 'bootstrap' will result in an error`
`75`		`- // when an error happens. If we do not rethrow, bootstrap will always succeed.`
`76`	`74`	`if (this.rethrowError) throw error;`
`77`	`75`	`}`
`78`	`76`