fix(compiler): ensure JIT compilation of ɵɵngDeclarePipe() works (#40929)

petebacondarwin · zarend · commit 55eb7b5681ef · 2021-02-24T15:07:08.000-08:00
Previously the compiler was not evaluating the JIT compilation of `ɵɵngDeclarePipe()` but there was no test to check it. PR Close #40929
diff --git a/packages/compiler/src/jit_compiler_facade.ts b/packages/compiler/src/jit_compiler_facade.ts
@@ -54,7 +54,8 @@ export class CompilerFacadeImpl implements CompilerFacade {
       angularCoreEnv: CoreEnvironment, sourceMapUrl: string,
       declaration: R3DeclarePipeFacade): any {
     const meta = convertDeclarePipeFacadeToMetadata(declaration);
-    return compilePipeFromMetadata(meta);
+    const res = compilePipeFromMetadata(meta);
+    return this.jitExpression(res.expression, angularCoreEnv, sourceMapUrl, []);
   }
 
   compileInjectable(
diff --git a/packages/core/test/render3/jit/declare_pipe_spec.ts b/packages/core/test/render3/jit/declare_pipe_spec.ts
@@ -0,0 +1,30 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import {ɵɵngDeclarePipe} from '@angular/core';
+import {PipeDef} from '../../../src/render3';
+
+describe('Pipe declaration jit compilation', () => {
+  it('should compile a named Pipe declaration', () => {
+    const def = ɵɵngDeclarePipe({type: TestClass, name: 'foo'}) as PipeDef<TestClass>;
+
+    expect(def.type).toBe(TestClass);
+    expect(def.name).toEqual('foo');
+    expect(def.pure).toEqual(true);
+  });
+
+  it('should compile an impure Pipe declaration', () => {
+    const def = ɵɵngDeclarePipe({type: TestClass, name: 'foo', pure: false}) as PipeDef<TestClass>;
+
+    expect(def.type).toBe(TestClass);
+    expect(def.name).toEqual('foo');
+    expect(def.pure).toEqual(false);
+  });
+});
+
+class TestClass {}

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,8 @@ export class CompilerFacadeImpl implements CompilerFacade {`
`54`	`54`	`angularCoreEnv: CoreEnvironment, sourceMapUrl: string,`
`55`	`55`	`declaration: R3DeclarePipeFacade): any {`
`56`	`56`	`const meta = convertDeclarePipeFacadeToMetadata(declaration);`
`57`		`- return compilePipeFromMetadata(meta);`
	`57`	`+ const res = compilePipeFromMetadata(meta);`
	`58`	`+ return this.jitExpression(res.expression, angularCoreEnv, sourceMapUrl, []);`
`58`	`59`	`}`
`59`	`60`
`60`	`61`	`compileInjectable(`