Skip to content

Commit 52c74d3

Browse files
alan-agius4alxhub
authored andcommitted
fix(core): add additional component metadata to component ID generation (#50203)
This commit add `exportAs`, `signals`, `inputs` and `outputs` into account when generating a component ID. See: #50158 (comment) PR Close #50203
1 parent f751ce6 commit 52c74d3

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

packages/core/src/render3/definition.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,7 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
679679
// https://github.com/angular/components/blob/d9f82c8f95309e77a6d82fd574c65871e91354c2/src/material/core/option/option.ts#L248
680680
// https://github.com/angular/components/blob/285f46dc2b4c5b127d356cb7c4714b221f03ce50/src/material/legacy-core/option/option.ts#L32
681681

682-
const hashSelectors = [
682+
const hashSelectors = JSON.stringify([
683683
componentDef.selectors,
684684
componentDef.ngContentSelectors,
685685
componentDef.hostVars,
@@ -689,12 +689,16 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
689689
componentDef.decls,
690690
componentDef.encapsulation,
691691
componentDef.standalone,
692+
componentDef.signals,
693+
componentDef.exportAs,
694+
componentDef.inputs,
695+
componentDef.outputs,
692696
// We cannot use 'componentDef.type.name' as the name of the symbol will change and will not
693697
// match in the server and browser bundles.
694698
Object.getOwnPropertyNames(componentDef.type.prototype),
695699
!!componentDef.contentQueries,
696700
!!componentDef.viewQuery,
697-
].join('|');
701+
]);
698702

699703
for (const char of hashSelectors) {
700704
hash = Math.imul(31, hash) + char.charCodeAt(0) << 0;

0 commit comments

Comments
 (0)