fix(service-worker): update type castings for JSON.parse usage (#40710)

josephperrott · alxhub · commit 4f7ff96e502e · 2021-02-09T10:48:43.000-08:00
Update usages of JSON.parse to be cast as specific types. PR Close #40710
diff --git a/packages/service-worker/cli/main.ts b/packages/service-worker/cli/main.ts
@@ -6,10 +6,11 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-const {Generator, NgswConfig} = require('@angular/service-worker/config');
+const {Generator} = require('@angular/service-worker/config');
 const fs = require('fs');
 const path = require('path');
 import {NodeFilesystem} from './filesystem';
+import {Config} from '../config/src/in';
 
 
 const cwd = process.cwd();
@@ -18,7 +19,7 @@ const distDir = path.join(cwd, process.argv[2]);
 const config = path.join(cwd, process.argv[3]);
 const baseHref = process.argv[4] || '/';
 
-const configParsed = JSON.parse(fs.readFileSync(config).toString());
+const configParsed = JSON.parse(fs.readFileSync(config).toString()) as Config;
 
 const filesystem = new NodeFilesystem(distDir);
 const gen = new Generator(filesystem, baseHref);
diff --git a/packages/service-worker/worker/test/happy_spec.ts b/packages/service-worker/worker/test/happy_spec.ts
@@ -994,7 +994,7 @@ describe('Driver', () => {
     const getClientAssignments = async (sw: SwTestHarness, baseHref: string) => {
       const cache = await sw.caches.open(`ngsw:${baseHref}:db:control`) as unknown as MockCache;
       const dehydrated = cache.dehydrate();
-      return JSON.parse(dehydrated['/assignments'].body!);
+      return JSON.parse(dehydrated['/assignments'].body!) as any;
     };
 
     const initializeSwFor = async (baseHref: string, initialCacheState = '{}') => {
diff --git a/packages/service-worker/worker/testing/fetch.ts b/packages/service-worker/worker/testing/fetch.ts
@@ -29,7 +29,7 @@ export class MockBody implements Body {
   }
 
   async json(): Promise<any> {
-    return JSON.parse(this.getBody());
+    return JSON.parse(this.getBody()) as any;
   }
 
   async text(): Promise<string> {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export class MockBody implements Body {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`async json(): Promise<any> {`
`32`		`- return JSON.parse(this.getBody());`
	`32`	`+ return JSON.parse(this.getBody()) as any;`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`async text(): Promise<string> {`