Skip to content

Commit 3e34d7f

Browse files
committed
docs(docs-infra): Remove internal constructors from the doc.
Internal constructor should not be exposed in the doc. This removes them. Related to #50281
1 parent 85b4941 commit 3e34d7f

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

aio/tools/transforms/angular-api-package/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ module.exports =
3737
.processor(require('./processors/computeSearchTitle'))
3838
.processor(require('./processors/simplifyMemberAnchors'))
3939
.processor(require('./processors/computeStability'))
40-
.processor(require('./processors/removeInjectableConstructors'))
40+
.processor(require('./processors/removeInjectableAndInternalConstructors'))
4141
.processor(require('./processors/processSpecialElements'))
4242
.processor(require('./processors/collectPackageContentDocs'))
4343
.processor(require('./processors/processPackages'))

aio/tools/transforms/angular-api-package/processors/removeInjectableConstructors.js renamed to aio/tools/transforms/angular-api-package/processors/removeInjectableAndInternalConstructors.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module.exports = function removeInjectableConstructors() {
1+
module.exports = function removeInjectableAndInternalConstructors() {
22
return {
33
$runAfter: ['processing-docs', 'splitDescription'],
44
$runBefore: ['docs-processed'],
@@ -12,6 +12,9 @@ module.exports = function removeInjectableConstructors() {
1212
doc.decorators.some(decorator => this.injectableDecorators.indexOf(decorator.name) !== -1)) {
1313
delete doc.constructorDoc;
1414
}
15+
if(doc.constructorDoc && doc.constructorDoc.internal) {
16+
delete doc.constructorDoc;
17+
}
1518
});
1619
}
1720
};

aio/tools/transforms/angular-api-package/processors/removeInjectableConstructors.spec.js renamed to aio/tools/transforms/angular-api-package/processors/removeInjectableAndInternalConstructors.spec.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const processorFactory = require('./removeInjectableConstructors');
1+
const processorFactory = require('./removeInjectableAndInternalConstructors');
22
const testPackage = require('../../helpers/test-package');
33
const Dgeni = require('dgeni');
44

@@ -7,7 +7,7 @@ describe('removeInjectableConstructors processor', () => {
77
it('should be available on the injector', () => {
88
const dgeni = new Dgeni([testPackage('angular-api-package')]);
99
const injector = dgeni.configureInjector();
10-
const processor = injector.get('removeInjectableConstructors');
10+
const processor = injector.get('removeInjectableAndInternalConstructors');
1111
expect(processor.$process).toBeDefined();
1212
expect(processor.$runAfter).toEqual(['processing-docs', 'splitDescription']);
1313
expect(processor.$runBefore).toEqual(['docs-processed']);
@@ -23,6 +23,7 @@ describe('removeInjectableConstructors processor', () => {
2323
{ constructorDoc: {}, decorators: [{ name: 'Directive' }] },
2424
{ constructorDoc: {}, decorators: [{ name: 'Pipe' }] },
2525
{ constructorDoc: {}, decorators: [{ name: 'Other' }, { name: 'Injectable' }] },
26+
2627
{ constructorDoc: {}, decorators: [{ name: 'Other' }] },
2728

2829
{ constructorDoc: { shortDescription: 'Blah' } },
@@ -33,6 +34,8 @@ describe('removeInjectableConstructors processor', () => {
3334
{ constructorDoc: { shortDescription: 'Blah' }, decorators: [{ name: 'Pipe' }] },
3435
{ constructorDoc: { shortDescription: 'Blah' }, decorators: [{ name: 'Other' }, { name: 'Injectable' }] },
3536
{ constructorDoc: { shortDescription: 'Blah' }, decorators: [{ name: 'Other' }] },
37+
38+
{ constructorDoc: { internal: true } },
3639
];
3740

3841
processor.$process(docs);
@@ -54,5 +57,7 @@ describe('removeInjectableConstructors processor', () => {
5457
expect(docs[13].constructorDoc).toBeDefined();
5558
expect(docs[14].constructorDoc).toBeDefined();
5659
expect(docs[15].constructorDoc).toBeDefined();
60+
61+
expect(docs[16].constructorDoc).toBeUndefined();
5762
});
5863
});

0 commit comments

Comments
 (0)