fix(compiler): provide location information for literal map keys

crisbeto · crisbeto · commit 3c3ae0cb64bb · 2026-01-02T08:18:06.000+01:00
Adds spans for the keys of a `LiteralMap`. Fixes #66175. (cherry picked from commit 76fa180)
diff --git a/packages/compiler/src/expression_parser/ast.ts b/packages/compiler/src/expression_parser/ast.ts
@@ -218,11 +218,13 @@ export class LiteralArray extends AST {
   }
 }
 
-export type LiteralMapKey = {
+export interface LiteralMapKey {
   key: string;
   quoted: boolean;
+  span: ParseSpan;
+  sourceSpan: AbsoluteSourceSpan;
   isShorthandInitialized?: boolean;
-};
+}
 
 export class LiteralMap extends AST {
   constructor(
diff --git a/packages/compiler/src/expression_parser/parser.ts b/packages/compiler/src/expression_parser/parser.ts
@@ -1197,7 +1197,14 @@ class _ParseAST {
         const keyStart = this.inputIndex;
         const quoted = this.next.isString();
         const key = this.expectIdentifierOrKeywordOrString();
-        const literalMapKey: LiteralMapKey = {key, quoted};
+        const keySpan = this.span(keyStart);
+        const keySourceSpan = this.sourceSpan(keyStart);
+        const literalMapKey: LiteralMapKey = {
+          key,
+          quoted,
+          span: keySpan,
+          sourceSpan: keySourceSpan,
+        };
         keys.push(literalMapKey);
 
         // Properties with quoted keys can't use the shorthand syntax.
@@ -1209,14 +1216,12 @@ class _ParseAST {
         } else {
           literalMapKey.isShorthandInitialized = true;
 
-          const span = this.span(keyStart);
-          const sourceSpan = this.sourceSpan(keyStart);
           values.push(
             new PropertyRead(
-              span,
-              sourceSpan,
-              sourceSpan,
-              new ImplicitReceiver(span, sourceSpan),
+              keySpan,
+              keySourceSpan,
+              keySourceSpan,
+              new ImplicitReceiver(keySpan, keySourceSpan),
               key,
             ),
           );
diff --git a/packages/compiler/test/expression_parser/parser_spec.ts b/packages/compiler/test/expression_parser/parser_spec.ts
@@ -18,6 +18,7 @@ import {
   TemplateBinding,
   VariableBinding,
   BindingPipeType,
+  ParseSpan,
 } from '../../src/expression_parser/ast';
 import {ParseError} from '../../src/parse_util';
 import {Lexer} from '../../src/expression_parser/lexer';
@@ -733,6 +734,17 @@ describe('parser', () => {
         '/^http:\\/\\/foo\\.bar/gim',
       ]);
     });
+
+    it('should record span for literal map keys', () => {
+      const ast = parseBinding('{one: 1, two: "the number two", three, "four": 4}');
+      const literal = ast.ast as LiteralMap;
+      const getSource = (span: ParseSpan) => ast.source?.substring(span.start, span.end);
+
+      expect(getSource(literal.keys[0].span)).toBe('one');
+      expect(getSource(literal.keys[1].span)).toBe('two');
+      expect(getSource(literal.keys[2].span)).toBe('three');
+      expect(getSource(literal.keys[3].span)).toBe('"four"');
+    });
   });
 
   describe('general error handling', () => {

Original file line number	Diff line number	Diff line change
`@@ -218,11 +218,13 @@ export class LiteralArray extends AST {`
`218`	`218`	`}`
`219`	`219`	`}`
`220`	`220`
`221`		`-export type LiteralMapKey = {`
	`221`	`+export interface LiteralMapKey {`
`222`	`222`	`key: string;`
`223`	`223`	`quoted: boolean;`
	`224`	`+ span: ParseSpan;`
	`225`	`+ sourceSpan: AbsoluteSourceSpan;`
`224`	`226`	`isShorthandInitialized?: boolean;`
`225`		`-};`
	`227`	`+}`
`226`	`228`
`227`	`229`	`export class LiteralMap extends AST {`
`228`	`230`	`constructor(`