fix(compiler): type-only symbols incorrectly retained when downlevelling custom decorators (#48638)

crisbeto · alxhub · commit 33f35b04ef0f · 2023-01-04T12:29:16.000-08:00
In #47167 an `updateClassDeclaration` call was swapped out with a `createClassDeclaration` which caused a regression where interface references were being retained when using a custom decorator in a project that has `emitDecoratorMetadata` enabled. These changes switch back to use `updateClassDeclaration`. Fixes #48448. PR Close #48638
diff --git a/packages/compiler-cli/src/transformers/downlevel_decorators_transform/downlevel_decorators_transform.ts b/packages/compiler-cli/src/transformers/downlevel_decorators_transform/downlevel_decorators_transform.ts
@@ -576,8 +576,9 @@ export function getDownlevelDecoratorsTransform(
         modifiers = [...decoratorsToKeep, ...(classModifiers || [])];
       }
 
-      return ts.factory.createClassDeclaration(
-          modifiers, classDecl.name, classDecl.typeParameters, classDecl.heritageClauses, members);
+      return ts.factory.updateClassDeclaration(
+          classDecl, modifiers, classDecl.name, classDecl.typeParameters, classDecl.heritageClauses,
+          members);
     }
 
     /**
diff --git a/packages/compiler-cli/test/downlevel_decorators_transform_spec.ts b/packages/compiler-cli/test/downlevel_decorators_transform_spec.ts
@@ -702,6 +702,33 @@ describe('downlevel decorator transform', () => {
     expect(output).not.toContain('tslib');
   });
 
+  it('should allow for type-only references to be removed with `emitDecoratorMetadata` from custom decorators',
+     () => {
+       context.writeFile('/external-interface.ts', `
+        export interface ExternalInterface {
+          id?: string;
+        }
+      `);
+
+       const {output} = transform(
+           `
+            import { ExternalInterface } from './external-interface';
+
+            export function CustomDecorator() {
+              return <T>(target, propertyKey, descriptor: TypedPropertyDescriptor<T>) => {}
+            }
+
+            export class Foo {
+              @CustomDecorator() static test(): ExternalInterface { return {}; }
+            }
+          `,
+           {emitDecoratorMetadata: true});
+
+       expect(diagnostics.length).toBe(0);
+       expect(output).not.toContain('ExternalInterface');
+       expect(output).toContain('metadata("design:returntype", Object)');
+     });
+
   describe('class decorators skipped', () => {
     beforeEach(() => skipClassDecorators = true);
 

Original file line number	Diff line number	Diff line change
`@@ -576,8 +576,9 @@ export function getDownlevelDecoratorsTransform(`
`576`	`576`	`modifiers = [...decoratorsToKeep, ...(classModifiers \|\| [])];`
`577`	`577`	`}`
`578`	`578`
`579`		`- return ts.factory.createClassDeclaration(`
`580`		`- modifiers, classDecl.name, classDecl.typeParameters, classDecl.heritageClauses, members);`
	`579`	`+ return ts.factory.updateClassDeclaration(`
	`580`	`+ classDecl, modifiers, classDecl.name, classDecl.typeParameters, classDecl.heritageClauses,`
	`581`	`+ members);`
`581`	`582`	`}`
`582`	`583`
`583`	`584`	`/**`