fix(migrations): Do not remove a template if it is referenced even with a trailing semilocon

lukasmatta · crisbeto · commit 2edc82abe0cf · 2025-10-29T10:51:00.000+01:00
This commit fixes a behavior where under certain conditions, the migration script ignored a template reference with a trailing semicolon and incorrectly removed the definition of a referenced template. Fixes #64741 (cherry picked from commit 64cb085)
diff --git a/packages/core/schematics/migrations/control-flow-migration/util.ts b/packages/core/schematics/migrations/control-flow-migration/util.ts
@@ -551,7 +551,7 @@ function analyzeTemplateUsage(nodes: any[], templateName: string): TemplateUsage
         for (const attr of node.attrs) {
           if (
             (attr.name === '*ngTemplateOutlet' || attr.name === '[ngTemplateOutlet]') &&
-            attr.value === templateName
+            attr.value?.split(';')[0] === templateName
           ) {
             isReferencedInTemplateOutlet = true;
           }
diff --git a/packages/core/schematics/test/control_flow_migration_spec.ts b/packages/core/schematics/test/control_flow_migration_spec.ts
@@ -1395,6 +1395,52 @@ describe('control flow migration (ng update)', () => {
       );
     });
 
+    it('should migrate but not remove ng-templates when referenced elsewhere with a trailing semicolon', async () => {
+      writeFile(
+        '/comp.ts',
+        `
+        import {Component} from '@angular/core';
+        import {NgIf} from '@angular/common';
+
+        @Component({
+          templateUrl: './comp.html'
+        })
+        class Comp {
+          show = false;
+        }
+      `,
+      );
+
+      writeFile(
+        '/comp.html',
+        [
+          `<div>`,
+          `<span *ngIf="show; then thenBlock; else elseBlock">Ignored</span>`,
+          `<ng-template #thenBlock><div>THEN Stuff</div></ng-template>`,
+          `<ng-template #elseBlock>Else Content</ng-template>`,
+          `</div>`,
+          `<ng-container *ngTemplateOutlet="elseBlock;"></ng-container>`,
+        ].join('\n'),
+      );
+
+      await runMigration();
+      const content = tree.readContent('/comp.html');
+
+      expect(content).toBe(
+        [
+          `<div>`,
+          `  @if (show) {`,
+          `    <div>THEN Stuff</div>`,
+          `  } @else {`,
+          `    Else Content`,
+          `  }`,
+          `  <ng-template #elseBlock>Else Content</ng-template>`,
+          `</div>`,
+          `<ng-container *ngTemplateOutlet="elseBlock;"></ng-container>`,
+        ].join('\n'),
+      );
+    });
+
     it('should not remove ng-templates used by other directives', async () => {
       writeFile(
         '/comp.ts',

Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,7 @@ function analyzeTemplateUsage(nodes: any[], templateName: string): TemplateUsage`
`551`	`551`	`for (const attr of node.attrs) {`
`552`	`552`	`if (`
`553`	`553`	`(attr.name === '*ngTemplateOutlet' \|\| attr.name === '[ngTemplateOutlet]') &&`
`554`		`- attr.value === templateName`
	`554`	`+ attr.value?.split(';')[0] === templateName`
`555`	`555`	`) {`
`556`	`556`	`isReferencedInTemplateOutlet = true;`
`557`	`557`	`}`