refactor(core): remove legacy way of preventing default actions (#50257)

crisbeto · AndrewKushnir · commit 239e7e6de3d2 · 2023-05-15T09:22:33.000-07:00
Setting `returnValue = false` to prevent the default action of events hasn't been necessary since IE9. PR Close #50257
diff --git a/packages/core/src/render3/instructions/listener.ts b/packages/core/src/render3/instructions/listener.ts
@@ -271,8 +271,6 @@ function wrapListener(
 
     if (wrapWithPreventDefault && result === false) {
       e.preventDefault();
-      // Necessary for legacy browsers that don't support preventDefault (e.g. IE)
-      e.returnValue = false;
     }
 
     return result;
diff --git a/packages/platform-browser/src/dom/dom_renderer.ts b/packages/platform-browser/src/dom/dom_renderer.ts
@@ -318,7 +318,6 @@ class DefaultDomRenderer2 implements Renderer2 {
           eventHandler(event);
       if (allowDefaultBehavior === false) {
         event.preventDefault();
-        event.returnValue = false;
       }
 
       return undefined;

Original file line number	Diff line number	Diff line change
`@@ -271,8 +271,6 @@ function wrapListener(`
`271`	`271`
`272`	`272`	`if (wrapWithPreventDefault && result === false) {`
`273`	`273`	`e.preventDefault();`
`274`		`- // Necessary for legacy browsers that don't support preventDefault (e.g. IE)`
`275`		`- e.returnValue = false;`
`276`	`274`	`}`
`277`	`275`
`278`	`276`	`return result;`
Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,6 @@ class DefaultDomRenderer2 implements Renderer2 {`
`318`	`318`	`eventHandler(event);`
`319`	`319`	`if (allowDefaultBehavior === false) {`
`320`	`320`	`event.preventDefault();`
`321`		`- event.returnValue = false;`
`322`	`321`	`}`
`323`	`322`
`324`	`323`	`return undefined;`