Skip to content

Commit 237d90f

Browse files
committed
Revert "fix(core): add additional component metadata to component ID generation (#50203)" (#50334)
This reverts commit 52c74d3. The reason for revert: breaking some apps in Google's codebase. PR Close #50334
1 parent a898d9f commit 237d90f

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

packages/core/src/render3/definition.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
686686
// https://github.com/angular/components/blob/d9f82c8f95309e77a6d82fd574c65871e91354c2/src/material/core/option/option.ts#L248
687687
// https://github.com/angular/components/blob/285f46dc2b4c5b127d356cb7c4714b221f03ce50/src/material/legacy-core/option/option.ts#L32
688688

689-
const hashSelectors = JSON.stringify([
689+
const hashSelectors = [
690690
componentDef.selectors,
691691
componentDef.ngContentSelectors,
692692
componentDef.hostVars,
@@ -696,16 +696,12 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
696696
componentDef.decls,
697697
componentDef.encapsulation,
698698
componentDef.standalone,
699-
componentDef.signals,
700-
componentDef.exportAs,
701-
componentDef.inputs,
702-
componentDef.outputs,
703699
// We cannot use 'componentDef.type.name' as the name of the symbol will change and will not
704700
// match in the server and browser bundles.
705701
Object.getOwnPropertyNames(componentDef.type.prototype),
706702
!!componentDef.contentQueries,
707703
!!componentDef.viewQuery,
708-
]);
704+
].join('|');
709705

710706
for (const char of hashSelectors) {
711707
hash = Math.imul(31, hash) + char.charCodeAt(0) << 0;

0 commit comments

Comments
 (0)