fix(platform-browser): KeyEventsPlugin should keep the same behavior (#49330)

JiaLiPassion · thePunderWoman · commit 2312eb53ef58 · 2023-03-06T18:45:01.000Z
Close #45698 KeyEventsPlugin now has different behavior with EventsPlugin, it will always run inside ngZone with ngZone.runGuarded() no matter the component is initialized inside or outside of NgZone, this PR make sure KeyEventsPlugin bahave the same with other events. PR Close #49330
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -605,9 +605,6 @@
   {
     "name": "getCurrentTNodePlaceholderOk"
   },
-  {
-    "name": "getDOM"
-  },
   {
     "name": "getDeclarationTNode"
   },
diff --git a/packages/platform-browser/src/dom/events/key_events.ts b/packages/platform-browser/src/dom/events/key_events.ts
@@ -78,12 +78,9 @@ export class KeyEventsPlugin extends EventManagerPlugin {
   override addEventListener(element: HTMLElement, eventName: string, handler: Function): Function {
     const parsedEvent = KeyEventsPlugin.parseEventName(eventName)!;
 
-    const outsideHandler =
-        KeyEventsPlugin.eventCallback(parsedEvent['fullKey'], handler, this.manager.getZone());
+    const outsideHandler = KeyEventsPlugin.eventCallback(parsedEvent['fullKey'], handler);
 
-    return this.manager.getZone().runOutsideAngular(() => {
-      return getDOM().onAndCancel(element, parsedEvent['domEventName'], outsideHandler);
-    });
+    return this.manager.addEventListener(element, parsedEvent['domEventName'], outsideHandler);
   }
 
   /**
@@ -178,10 +175,10 @@ export class KeyEventsPlugin extends EventManagerPlugin {
    * @param zone The zone in which the event occurred.
    * @returns A callback function.
    */
-  static eventCallback(fullKey: string, handler: Function, zone: NgZone): Function {
+  static eventCallback(fullKey: string, handler: Function): Function {
     return (event: KeyboardEvent) => {
       if (KeyEventsPlugin.matchEventFullKeyCode(event, fullKey)) {
-        zone.runGuarded(() => handler(event));
+        handler(event);
       }
     };
   }

Original file line number	Diff line number	Diff line change
`@@ -605,9 +605,6 @@`
`605`	`605`	`{`
`606`	`606`	`"name": "getCurrentTNodePlaceholderOk"`
`607`	`607`	`},`
`608`		`- {`
`609`		`- "name": "getDOM"`
`610`		`- },`
`611`	`608`	`{`
`612`	`609`	`"name": "getDeclarationTNode"`
`613`	`610`	`},`