fix(core): resolver function not matching expected type

crisbeto · leonsenft · commit 22f8b0a50080 · 2026-03-20T15:18:29.000-07:00
Fixes that the `ɵɵresolveWindow` function wasn't match the type expected by `ɵɵlistener`. I've also added explicit type annotations to make cases like this easier to catch.
diff --git a/packages/core/src/hydration/node_lookup_utils.ts b/packages/core/src/hydration/node_lookup_utils.ts
@@ -247,7 +247,7 @@ function locateRNodeByPath(path: string, lView: LView): RNode {
   } else if (referenceNode === REFERENCE_NODE_BODY) {
     ref = ɵɵresolveBody(
       lView[DECLARATION_COMPONENT_VIEW][HOST] as RElement & {ownerDocument: Document},
-    );
+    ) as Element;
   } else {
     const parentElementId = Number(referenceNode);
     ref = unwrapRNode((lView as any)[parentElementId + HEADER_OFFSET]) as Element;
diff --git a/packages/core/src/render3/util/misc_utils.ts b/packages/core/src/render3/util/misc_utils.ts
@@ -12,23 +12,23 @@ import {RElement} from '../interfaces/renderer_dom';
  *
  * @codeGenApi
  */
-export function ɵɵresolveWindow(element: RElement & {ownerDocument: Document}) {
-  return element.ownerDocument.defaultView;
+export function ɵɵresolveWindow(element: RElement & {ownerDocument: Document}): EventTarget {
+  return element.ownerDocument.defaultView!;
 }
 
 /**
  *
  * @codeGenApi
  */
-export function ɵɵresolveDocument(element: RElement & {ownerDocument: Document}) {
+export function ɵɵresolveDocument(element: RElement & {ownerDocument: Document}): EventTarget {
   return element.ownerDocument;
 }
 
 /**
  *
  * @codeGenApi
  */
-export function ɵɵresolveBody(element: RElement & {ownerDocument: Document}) {
+export function ɵɵresolveBody(element: RElement & {ownerDocument: Document}): EventTarget {
   return element.ownerDocument.body;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -12,23 +12,23 @@ import {RElement} from '../interfaces/renderer_dom';`
`12`	`12`	`*`
`13`	`13`	`* @codeGenApi`
`14`	`14`	`*/`
`15`		`-export function ɵɵresolveWindow(element: RElement & {ownerDocument: Document}) {`
`16`		`- return element.ownerDocument.defaultView;`
	`15`	`+export function ɵɵresolveWindow(element: RElement & {ownerDocument: Document}): EventTarget {`
	`16`	`+ return element.ownerDocument.defaultView!;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`/**`
`20`	`20`	`*`
`21`	`21`	`* @codeGenApi`
`22`	`22`	`*/`
`23`		`-export function ɵɵresolveDocument(element: RElement & {ownerDocument: Document}) {`
	`23`	`+export function ɵɵresolveDocument(element: RElement & {ownerDocument: Document}): EventTarget {`
`24`	`24`	`return element.ownerDocument;`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`/**`
`28`	`28`	`*`
`29`	`29`	`* @codeGenApi`
`30`	`30`	`*/`
`31`		`-export function ɵɵresolveBody(element: RElement & {ownerDocument: Document}) {`
	`31`	`+export function ɵɵresolveBody(element: RElement & {ownerDocument: Document}): EventTarget {`
`32`	`32`	`return element.ownerDocument.body;`
`33`	`33`	`}`
`34`	`34`