fix(core): toObservable should allow writes to signals in the effect (#49769)

atscott · AndrewKushnir · commit 1dddb7878688 · 2023-04-12T09:35:55.000-07:00
`toObservable` creates an `effect` that watches for updates to the source signal. We should allow writes to signals in this effect, which would be consumed by downstream observers. PR Close #49769
diff --git a/packages/core/rxjs-interop/src/to_observable.ts b/packages/core/rxjs-interop/src/to_observable.ts
@@ -51,7 +51,7 @@ export function toObservable<T>(
         return;
       }
       observer.next(value);
-    }, {injector, manualCleanup: true});
+    }, {injector, manualCleanup: true, allowSignalWrites: true});
     return () => watcher.destroy();
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export function toObservable<T>(`
`51`	`51`	`return;`
`52`	`52`	`}`
`53`	`53`	`observer.next(value);`
`54`		`- }, {injector, manualCleanup: true});`
	`54`	`+ }, {injector, manualCleanup: true, allowSignalWrites: true});`
`55`	`55`	`return () => watcher.destroy();`
`56`	`56`	`});`
`57`	`57`	`}`