fix(router): Surface parse errors in Router.parseUrl (#64503)

atscott · thePunderWoman · commit 182fe78f91d0 · 2025-10-20T17:51:30.000Z
logs error in addition to fallback parse fixes #54937 PR Close #64503
diff --git a/goldens/public-api/router/errors.api.md b/goldens/public-api/router/errors.api.md
@@ -9,6 +9,8 @@ export const enum RuntimeErrorCode {
     // (undocumented)
     EMPTY_PATH_WITH_PARAMS = 4009,
     // (undocumented)
+    ERROR_PARSING_URL = 4018,
+    // (undocumented)
     FOR_ROOT_CALLED_TWICE = 4007,
     // (undocumented)
     INFINITE_REDIRECT = 4016,
diff --git a/packages/router/src/errors.ts b/packages/router/src/errors.ts
@@ -28,4 +28,5 @@ export const enum RuntimeErrorCode {
   INVALID_ROOT_URL_SEGMENT = 4015,
   INFINITE_REDIRECT = 4016,
   INVALID_ROUTER_LINK_INPUTS = 4017,
+  ERROR_PARSING_URL = 4018,
 }
diff --git a/packages/router/src/router.ts b/packages/router/src/router.ts
@@ -17,6 +17,7 @@ import {
   Type,
   untracked,
   ɵINTERNAL_APPLICATION_ERROR_HANDLER,
+  ɵformatRuntimeError as formatRuntimeError,
 } from '@angular/core';
 import {Observable, Subject, Subscription, SubscriptionLike} from 'rxjs';
 
@@ -580,7 +581,13 @@ export class Router {
   parseUrl(url: string): UrlTree {
     try {
       return this.urlSerializer.parse(url);
-    } catch {
+    } catch (e) {
+      this.console.warn(
+        formatRuntimeError(
+          RuntimeErrorCode.ERROR_PARSING_URL,
+          ngDevMode && `Error parsing URL ${url}. Falling back to '/' instead. \n` + e,
+        ),
+      );
       return this.urlSerializer.parse('/');
     }
   }
diff --git a/packages/router/test/router.spec.ts b/packages/router/test/router.spec.ts
@@ -7,7 +7,7 @@
  */
 
 import {Location} from '@angular/common';
-import {EnvironmentInjector, inject} from '@angular/core';
+import {EnvironmentInjector, inject, ɵConsole as Console} from '@angular/core';
 import {TestBed} from '@angular/core/testing';
 import {RouterModule} from '../index';
 import {of} from 'rxjs';
@@ -20,7 +20,7 @@ import {resolveData as resolveDataOperator} from '../src/operators/resolve_data'
 import {Router} from '../src/router';
 import {ChildrenOutletContexts} from '../src/router_outlet_context';
 import {createEmptyStateSnapshot, RouterStateSnapshot} from '../src/router_state';
-import {DefaultUrlSerializer, UrlTree} from '../src/url_tree';
+import {DefaultUrlSerializer, UrlSerializer, UrlTree} from '../src/url_tree';
 import {getAllRouteGuards} from '../src/utils/preactivation';
 import {TreeNode} from '../src/utils/tree';
 
@@ -108,6 +108,30 @@ describe('Router', () => {
     });
   });
 
+  describe('parseUrl', () => {
+    beforeEach(() => {
+      TestBed.configureTestingModule({imports: [RouterModule.forRoot([])]});
+    });
+
+    it('should log a warning and fall back to "/" when parsing fails', () => {
+      const router: Router = TestBed.inject(Router);
+      const urlSerializer: UrlSerializer = TestBed.inject(UrlSerializer);
+      const console: Console = TestBed.inject(Console);
+      spyOn(urlSerializer, 'parse').and.callFake((url: string) => {
+        if (url === 'invalid-url') {
+          throw new Error('test error');
+        }
+        // The fallback call should not be mocked
+        return new DefaultUrlSerializer().parse(url);
+      });
+      const spy = spyOn(console, 'warn');
+
+      const result = router.parseUrl('invalid-url');
+      expect(spy.calls.argsFor(0)).toMatch(/Error parsing URL/);
+      expect(result).toEqual(new DefaultUrlSerializer().parse('/'));
+    });
+  });
+
   describe('PreActivation', () => {
     const serializer = new DefaultUrlSerializer();
     let empty: RouterStateSnapshot;

Original file line number	Diff line number	Diff line change
`@@ -28,4 +28,5 @@ export const enum RuntimeErrorCode {`
`28`	`28`	`INVALID_ROOT_URL_SEGMENT = 4015,`
`29`	`29`	`INFINITE_REDIRECT = 4016,`
`30`	`30`	`INVALID_ROUTER_LINK_INPUTS = 4017,`
	`31`	`+ ERROR_PARSING_URL = 4018,`
`31`	`32`	`}`