refactor: various build and import specificer fixes for strict deps (#63324)

josephperrott · AndrewKushnir · commit 10b0927e15bb · 2025-08-22T14:45:34.000-07:00
Change direct deps in bazel targets and import specifiers within files to maintain strict deps requirements ahead of enabling strict deps tests in the repo PR Close #63324
diff --git a/adev/shared-docs/components/navigation-list/navigation-list.component.ts b/adev/shared-docs/components/navigation-list/navigation-list.component.ts
@@ -11,7 +11,7 @@ import {NavigationItem} from '../../interfaces/index';
 import {NavigationState} from '../../services/index';
 import {RouterLink, RouterLinkActive} from '@angular/router';
 import {IconComponent} from '../icon/icon.component';
-import {IsActiveNavigationItem} from '../../pipes/is-active-navigation-item.pipe';
+import {IsActiveNavigationItem} from '../../pipes';
 import {NgTemplateOutlet} from '@angular/common';
 import {MatTooltipModule} from '@angular/material/tooltip';
 
diff --git a/adev/shared-docs/components/search-dialog/BUILD.bazel b/adev/shared-docs/components/search-dialog/BUILD.bazel
@@ -27,6 +27,7 @@ ng_project(
         "//adev/shared-docs/directives",
         "//adev/shared-docs/interfaces",
         "//adev/shared-docs/pipes",
+        "//adev/shared-docs/providers",
         "//adev/shared-docs/services",
     ],
 )
diff --git a/adev/shared-docs/components/search-dialog/search-dialog.component.ts b/adev/shared-docs/components/search-dialog/search-dialog.component.ts
@@ -20,19 +20,18 @@ import {
   viewChildren,
 } from '@angular/core';
 
-import {WINDOW} from '../../providers/index';
-import {ClickOutside} from '../../directives/index';
-import {Search, SearchHistory} from '../../services/index';
+import {WINDOW} from '../../providers';
+import {ClickOutside, SearchItem} from '../../directives';
+import {Search, SearchHistory} from '../../services';
 
 import {TextField} from '../text-field/text-field.component';
 import {FormControl, ReactiveFormsModule} from '@angular/forms';
 import {ActiveDescendantKeyManager} from '@angular/cdk/a11y';
-import {SearchItem} from '../../directives/search-item/search-item.directive';
 import {takeUntilDestroyed} from '@angular/core/rxjs-interop';
 import {Router, RouterLink} from '@angular/router';
 import {fromEvent} from 'rxjs';
 import {AlgoliaIcon} from '../algolia-icon/algolia-icon.component';
-import {RelativeLink} from '../../pipes/relative-link.pipe';
+import {RelativeLink} from '../../pipes';
 import {SearchHistoryComponent} from '../search-history/search-history.component';
 
 @Component({
diff --git a/adev/shared-docs/components/search-history/BUILD.bazel b/adev/shared-docs/components/search-history/BUILD.bazel
@@ -38,6 +38,8 @@ ts_project(
         ":search-history",
         "//adev:node_modules/@angular/core",
         "//adev:node_modules/@angular/platform-browser",
+        "//adev:node_modules/@angular/router",
+        "//adev/shared-docs/providers",
         "//adev/shared-docs/services",
         "//adev/shared-docs/testing",
     ],
diff --git a/adev/shared-docs/components/search-history/search-history.component.ts b/adev/shared-docs/components/search-history/search-history.component.ts
@@ -21,7 +21,7 @@ import {ActiveDescendantKeyManager} from '@angular/cdk/a11y';
 
 import {SearchHistory} from '../../services';
 import {RelativeLink} from '../../pipes';
-import {SearchItem} from '../../directives/search-item/search-item.directive';
+import {SearchItem} from '../../directives';
 
 @Component({
   selector: 'docs-search-history',
diff --git a/adev/shared-docs/components/table-of-contents/table-of-contents.component.ts b/adev/shared-docs/components/table-of-contents/table-of-contents.component.ts
@@ -17,7 +17,7 @@ import {
 } from '@angular/core';
 import {Location, ViewportScroller} from '@angular/common';
 import {TableOfContentsLevel} from '../../interfaces/index';
-import {TableOfContentsLoader} from '../../services/table-of-contents-loader.service';
+import {TableOfContentsLoader} from '../../services';
 import {IconComponent} from '../icon/icon.component';
 
 @Component({
diff --git a/adev/shared-docs/components/viewers/BUILD.bazel b/adev/shared-docs/components/viewers/BUILD.bazel
@@ -26,9 +26,12 @@ ng_project(
         "//adev:node_modules/rxjs",
         "//adev/shared-docs/components/breadcrumb",
         "//adev/shared-docs/components/copy-source-code-button",
+        "//adev/shared-docs/components/icon",
         "//adev/shared-docs/components/table-of-contents",
         "//adev/shared-docs/interfaces",
         "//adev/shared-docs/providers",
+        "//adev/shared-docs/services",
+        "//adev/shared-docs/utils",
     ],
 )
 
diff --git a/adev/shared-docs/components/viewers/docs-viewer/docs-viewer.component.ts b/adev/shared-docs/components/viewers/docs-viewer/docs-viewer.component.ts
@@ -28,11 +28,11 @@ import {
   effect,
 } from '@angular/core';
 import {takeUntilDestroyed} from '@angular/core/rxjs-interop';
-import {TOC_SKIP_CONTENT_MARKER, NavigationState} from '../../../services/index';
+import {TOC_SKIP_CONTENT_MARKER, NavigationState} from '../../../services';
 import {TableOfContents} from '../../table-of-contents/table-of-contents.component';
 import {IconComponent} from '../../icon/icon.component';
-import {handleHrefClickEventWithRouter} from '../../../utils/index';
-import {Snippet} from '../../../interfaces/index';
+import {handleHrefClickEventWithRouter} from '../../../utils';
+import {Snippet} from '../../../interfaces';
 import {Router} from '@angular/router';
 import {fromEvent} from 'rxjs';
 
diff --git a/adev/shared-docs/directives/index.ts b/adev/shared-docs/directives/index.ts
@@ -8,3 +8,4 @@
 
 export * from './click-outside/click-outside.directive';
 export * from './external-link/external-link.directive';
+export * from './search-item/search-item.directive';
diff --git a/devtools/projects/ng-devtools-backend/src/lib/state-serializer/BUILD.bazel b/devtools/projects/ng-devtools-backend/src/lib/state-serializer/BUILD.bazel
@@ -9,6 +9,7 @@ ng_project(
         exclude = ["*.spec.ts"],
     ),
     deps = [
+        "//devtools/projects/ng-devtools-backend/src/lib:utils",
         "//devtools/projects/ng-devtools-backend/src/lib/directive-forest",
         "//devtools/projects/protocol",
     ],
diff --git a/devtools/projects/ng-devtools/src/lib/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/BUILD.bazel
@@ -28,6 +28,7 @@ ng_project(
         "//:node_modules/@angular/forms",
         "//:node_modules/@angular/material",
         "//:node_modules/rxjs",
+        "//devtools/projects/ng-devtools/src/lib/application-environment",
         "//devtools/projects/ng-devtools/src/lib/application-services:browser_styles",
         "//devtools/projects/ng-devtools/src/lib/application-services:frame_manager",
         "//devtools/projects/ng-devtools/src/lib/application-services:theme",
diff --git a/devtools/projects/ng-devtools/src/lib/application-services/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/application-services/BUILD.bazel
@@ -74,6 +74,7 @@ ts_test_library(
         "//:node_modules/@angular/common",
         "//:node_modules/@angular/core",
         "//devtools/projects/ng-devtools/src/lib/application-environment",
+        "//devtools/projects/ng-devtools/src/lib/application-operations",
         "//devtools/projects/ng-devtools/src/lib/application-providers:window",
         "//devtools/projects/ng-devtools/src/lib/application-services/test-utils:app_operations_mock",
         "//devtools/projects/ng-devtools/src/lib/application-services/test-utils:settings_mock",
diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/BUILD.bazel
@@ -23,6 +23,7 @@ ng_project(
         "//:node_modules/@angular/material",
         "//:node_modules/rxjs",
         "//devtools/projects/ng-devtools/src/lib/application-operations",
+        "//devtools/projects/ng-devtools/src/lib/application-services:frame_manager",
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest",
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/breadcrumbs",
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/component-data-source",
@@ -45,6 +46,12 @@ ts_test_library(
         "//:node_modules/@angular/platform-browser",
         "//:node_modules/tslib",
         "//devtools/projects/ng-devtools/src/lib/application-operations",
+        "//devtools/projects/ng-devtools/src/lib/application-services:frame_manager",
+        "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest",
+        "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/breadcrumbs",
+        "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/index-forest",
+        "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-resolver",
+        "//devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/property-tab",
         "//devtools/projects/protocol",
     ],
 )
diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/index-forest/index-forest.spec.ts b/devtools/projects/ng-devtools/src/lib/devtools-tabs/directive-explorer/directive-forest/index-forest/index-forest.spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {indexForest} from './';
+import {indexForest} from './index';
 import {DevToolsNode} from '../../../../../../../protocol';
 
 describe('indexForest', () => {
diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/frame-selector/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/frame-selector/BUILD.bazel
@@ -28,5 +28,6 @@ ng_project(
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/shared:estimate-frame-rate",
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/tab-update",
         "//devtools/projects/ng-devtools/src/lib/shared/button",
+        "//devtools/projects/protocol",
     ],
 )
diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer/flamegraph-visualizer/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer/flamegraph-visualizer/BUILD.bazel
@@ -26,5 +26,6 @@ ng_project(
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/record-formatter/flamegraph-formatter",
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer:recording-visualizer-types",
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer/profile-formatter",
+        "//devtools/projects/protocol",
     ],
 )
diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer/profile-formatter/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer/profile-formatter/BUILD.bazel
@@ -7,5 +7,6 @@ ts_project(
     srcs = ["profile-formatter.ts"],
     deps = [
         "//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/recording-timeline/recording-visualizer:recording-visualizer-types",
+        "//devtools/projects/protocol",
     ],
 )
diff --git a/devtools/projects/shell-browser/src/app/BUILD.bazel b/devtools/projects/shell-browser/src/app/BUILD.bazel
@@ -30,6 +30,7 @@ ng_project(
         "//devtools/projects/ng-devtools-backend",
         "//devtools/projects/ng-devtools-backend/src/lib:highlighter",
         "//devtools/projects/ng-devtools-backend/src/lib/component-tree",
+        "//devtools/projects/ng-devtools/src/lib/application-services:frame_manager",
         "//devtools/projects/protocol",
         "//devtools/projects/shell-browser/src/app:backend",
         "//devtools/projects/shell-browser/src/app:background",
diff --git a/devtools/src/app/devtools-app/BUILD.bazel b/devtools/src/app/devtools-app/BUILD.bazel
@@ -23,6 +23,7 @@ ng_project(
         "//:node_modules/@angular/router",
         "//devtools/projects/ng-devtools",
         "//devtools/projects/ng-devtools/src/lib/application-services:frame_manager",
+        "//devtools/projects/ng-devtools/src/lib/shared/split",
         "//devtools/projects/protocol",
         "//devtools/src:iframe_message_bus",
     ],
diff --git a/devtools/src/app/transfer-state.ts b/devtools/src/app/transfer-state.ts
@@ -8,7 +8,6 @@
 
 import {HttpClient} from '@angular/common/http';
 import {APP_ID, DOCUMENT, inject, makeStateKey, TransferState} from '@angular/core';
-import {firstValueFrom} from 'rxjs';
 
 /**
  * This function serializes the transfer state into the DOM.
diff --git a/packages/common/upgrade/BUILD.bazel b/packages/common/upgrade/BUILD.bazel
@@ -13,6 +13,7 @@ ng_project(
         ],
     ),
     deps = [
+        "//:node_modules/rxjs",
         "//packages/common",
         "//packages/core",
         "//packages/upgrade",
diff --git a/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts b/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
@@ -9,7 +9,7 @@
 import {NgtscProgram} from '../../src/ngtsc/program';
 import {CompilerOptions} from '../../src/transformers/api';
 import {createCompilerHost} from '../../src/transformers/compiler_host';
-import {platform} from 'os';
+import {platform} from 'node:os';
 import ts from 'typescript';
 
 import {ErrorCode, ngErrorCode} from '../../src/ngtsc/diagnostics';
diff --git a/packages/compiler-cli/test/ngtsc/template_mapping_spec.ts b/packages/compiler-cli/test/ngtsc/template_mapping_spec.ts
@@ -7,7 +7,7 @@
  */
 
 /// <reference types="node" />
-import {inspect} from 'util';
+import {inspect} from 'node:util';
 import ts from 'typescript';
 
 import {runInEachFileSystem} from '../../src/ngtsc/file_system/testing';
diff --git a/packages/compiler-cli/test/ngtsc/xi18n_spec.ts b/packages/compiler-cli/test/ngtsc/xi18n_spec.ts
@@ -8,7 +8,7 @@
 
 import {runInEachFileSystem} from '../../src/ngtsc/file_system/testing';
 import {loadStandardTestFiles} from '../../src/ngtsc/testing';
-import {platform} from 'os';
+import {platform} from 'node:os';
 
 import {NgtscTestEnvironment} from './env';
 
diff --git a/packages/core/rxjs-interop/BUILD.bazel b/packages/core/rxjs-interop/BUILD.bazel
@@ -15,6 +15,7 @@ ng_project(
     deps = [
         "//:node_modules/rxjs",
         "//packages/core",
+        "//packages/core/primitives/signals",
     ],
 )
 
diff --git a/packages/core/schematics/migrations/control-flow-migration/index.ts b/packages/core/schematics/migrations/control-flow-migration/index.ts
@@ -7,7 +7,7 @@
  */
 
 import {Rule, SchematicContext, SchematicsException, Tree} from '@angular-devkit/schematics';
-import {join, relative} from 'path';
+import {join, relative} from 'node:path';
 
 import {canMigrateFile, createMigrationProgram} from '../../utils/typescript/compiler_host';
 
diff --git a/packages/core/schematics/migrations/signal-migration/src/batch/test_bin.ts b/packages/core/schematics/migrations/signal-migration/src/batch/test_bin.ts
@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import fs from 'fs';
-import path from 'path';
+import fs from 'node:fs';
+import path from 'node:path';
 import {executeAnalyzePhase} from '../../../../utils/tsurge/executors/analyze_exec';
 import {executeMigratePhase} from '../../../../utils/tsurge/executors/migrate_exec';
 import {SignalInputMigration} from '../migration';
diff --git a/packages/core/schematics/migrations/signal-migration/src/cli.ts b/packages/core/schematics/migrations/signal-migration/src/cli.ts
@@ -6,9 +6,9 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import path from 'path';
+import path from 'node:path';
 
-import assert from 'assert';
+import assert from 'node:assert';
 import {SignalInputMigration} from './migration';
 import {writeMigrationReplacements} from './write_replacements';
 import {NodeJSFileSystem} from '../../../../../compiler-cli';
diff --git a/packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts b/packages/core/schematics/migrations/signal-migration/src/convert-input/convert_to_signal.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import assert from 'assert';
+import assert from 'node:assert';
 import ts from 'typescript';
 
 import {ConvertInputPreparation} from './prepare_and_check';
diff --git a/packages/core/schematics/migrations/signal-migration/src/convert-input/prepare_and_check.ts b/packages/core/schematics/migrations/signal-migration/src/convert-input/prepare_and_check.ts
@@ -14,7 +14,7 @@ import {
 } from '../passes/problematic_patterns/incompatibility';
 import {InputNode} from '../input_detection/input_node';
 import {Decorator} from '@angular/compiler-cli/src/ngtsc/reflection';
-import assert from 'assert';
+import assert from 'node:assert';
 import {NgCompilerOptions} from '@angular/compiler-cli/src/ngtsc/core/api';
 
 /**
diff --git a/packages/core/schematics/migrations/signal-migration/src/flow_analysis/index.ts b/packages/core/schematics/migrations/signal-migration/src/flow_analysis/index.ts
@@ -11,7 +11,7 @@ import ts from 'typescript';
 import {getControlFlowContainer, isControlFlowBoundary} from './flow_containers';
 import {getFlowNode, traverseFlowForInterestingNodes} from './flow_node_traversal';
 import {unwrapParent} from '../utils/unwrap_parent';
-import assert from 'assert';
+import assert from 'node:assert';
 
 /**
  * Type describing an index of a node inside a control flow
diff --git a/packages/core/test/acceptance/selectorless/BUILD b/packages/core/test/acceptance/selectorless/BUILD
@@ -1,13 +1,20 @@
-load("//tools:defaults2.bzl", "angular_jasmine_test", "ng_project", "ng_web_test_suite")
+load("//tools:defaults2.bzl", "angular_jasmine_test", "ng_project", "ng_web_test_suite", "ts_config")
 
 package(default_visibility = ["//visibility:private"])
 
+ts_config(
+    name = "tsconfig",
+    src = "tsconfig.json",
+    deps = [
+        "//packages/core:tsconfig_test",
+    ],
+)
+
 ng_project(
     name = "selectorless_test_lib",
     testonly = True,
     srcs = glob(["**/*.ts"]),
-    extends = "//packages/core:tsconfig_test",
-    tsconfig = ":tsconfig.json",
+    tsconfig = ":tsconfig",
     visibility = ["//:__pkg__"],
     deps = [
         "//packages/core",
diff --git a/packages/core/test/render3/BUILD.bazel b/packages/core/test/render3/BUILD.bazel
@@ -65,20 +65,11 @@ ts_project(
     ],
 )
 
-ts_project(
-    name = "render3_node_lib",
-    testonly = True,
-    srcs = [],
-    deps = [
-        ":domino",
-        ":render3_lib",
-    ],
-)
-
 angular_jasmine_test(
     name = "render3",
     data = [
-        ":render3_node_lib",
+        ":domino",
+        ":render3_lib",
     ],
 )
 
diff --git a/packages/core/test/resource/BUILD.bazel b/packages/core/test/resource/BUILD.bazel
@@ -10,6 +10,7 @@ ng_project(
     ),
     deps = [
         "//packages/core",
+        "//packages/core/src/util",
         "//packages/core/testing",
     ],
 )
diff --git a/packages/core/test/strict_types/BUILD.bazel b/packages/core/test/strict_types/BUILD.bazel
@@ -6,7 +6,7 @@ ts_config(
     name = "tsconfig",
     src = "tsconfig.json",
     deps = [
-        "//packages:tsconfig_test",
+        "//packages/core:tsconfig_test",
     ],
 )
 
@@ -16,7 +16,6 @@ ts_project(
     srcs = glob(
         ["**/*.ts"],
     ),
-    extends = "//packages/core:tsconfig_test",
     tsconfig = ":tsconfig",
     deps = [
         "//packages/core",
diff --git a/packages/language-service/src/refactorings/BUILD.bazel b/packages/language-service/src/refactorings/BUILD.bazel
@@ -17,6 +17,7 @@ ts_project(
         "//packages/compiler-cli/src/ngtsc/reflection",
         "//packages/core/schematics/migrations/signal-migration/src",
         "//packages/core/schematics/migrations/signal-queries-migration:migration",
+        "//packages/core/schematics/utils/tsurge",
         "//packages/language-service:api",
         "//packages/language-service/src/utils",
     ],
diff --git a/packages/localize/tools/test/BUILD.bazel b/packages/localize/tools/test/BUILD.bazel
@@ -9,6 +9,7 @@ ts_project(
     visibility = ["//packages/localize/tools/test:__subpackages__"],
     deps = [
         "//:node_modules/@babel/generator",
+        "//:node_modules/@types/babel__core",
         "//:node_modules/@types/babel__generator",
         "//:node_modules/tinyglobby",
         "//packages:types",
diff --git a/packages/platform-server/test/BUILD.bazel b/packages/platform-server/test/BUILD.bazel
@@ -44,6 +44,7 @@ ts_project(
         "//packages/platform-browser",
         "//packages/platform-browser/animations",
         "//packages/platform-server",
+        "//packages/platform-server:bundled_domino_lib",
         "//packages/private/testing",
         "//packages/router",
     ],
diff --git a/packages/upgrade/static/BUILD.bazel b/packages/upgrade/static/BUILD.bazel
diff --git a/packages/upgrade/static/testing/BUILD.bazel b/packages/upgrade/static/testing/BUILD.bazel
diff --git a/packages/zone.js/test/closure/zone.closure.ts b/packages/zone.js/test/closure/zone.closure.ts
diff --git a/tools/testing/BUILD.bazel b/tools/testing/BUILD.bazel

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ ng_project(`
`27`	`27`	`"//adev/shared-docs/directives",`
`28`	`28`	`"//adev/shared-docs/interfaces",`
`29`	`29`	`"//adev/shared-docs/pipes",`
	`30`	`+ "//adev/shared-docs/providers",`
`30`	`31`	`"//adev/shared-docs/services",`
`31`	`32`	`],`
`32`	`33`	`)`
Original file line number	Diff line number	Diff line change
`@@ -8,3 +8,4 @@`
`8`	`8`
`9`	`9`	`export * from './click-outside/click-outside.directive';`
`10`	`10`	`export * from './external-link/external-link.directive';`
	`11`	`+export * from './search-item/search-item.directive';`