Repository navigation
Commit 525435b
authored
[flutter_tools] Only pass on a valid root tool in DASH__TOOL (flutter#196228)
When flutter_tools starts a sub-process, it propagates DASH__TOOL so the
sub-tool's analytics can attribute events to the user's entry point (the
root tool). Until now it passed the parent's value through unchanged,
even when that value was an unknown label or a shared component such as
analysis-server or dart-mcp-server, which can never be a root tool.
Since package:unified_analytics 8.4.0 (rolled in flutter#195950), the tool
itself ignores such values and reports root_tool = flutter-tool, but its
children would still receive the invalid value and disagree about the
root tool. This change only passes on a DASH__TOOL that names a tool
that can be a root tool. It prefers the parent's value, then a
caller-supplied value, and otherwise uses flutter-tool. This matches how
package:unified_analytics resolves the root tool.
Valid values are passed through exactly as before.
Fixes flutter#1949831 parent 42cd7ee commit 525435b
2 files changed
Lines changed: 93 additions & 5 deletions
File tree
- packages/flutter_tools
- lib/src/base
- test/general.shard/base
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1251 | 1251 | | |
1252 | 1252 | | |
1253 | 1253 | | |
1254 | | - | |
1255 | | - | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
1256 | 1262 | | |
1257 | | - | |
| 1263 | + | |
1258 | 1264 | | |
1259 | 1265 | | |
1260 | 1266 | | |
1261 | 1267 | | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
1262 | 1278 | | |
1263 | 1279 | | |
1264 | 1280 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
537 | | - | |
| 537 | + | |
538 | 538 | | |
539 | 539 | | |
540 | 540 | | |
| |||
600 | 600 | | |
601 | 601 | | |
602 | 602 | | |
603 | | - | |
| 603 | + | |
604 | 604 | | |
605 | 605 | | |
606 | 606 | | |
| |||
614 | 614 | | |
615 | 615 | | |
616 | 616 | | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
617 | 689 | | |
618 | 690 | | |
619 | 691 | | |
| |||
0 commit comments