Move presubmit to pull request instead of pull request target#202
Closed
yigit wants to merge 1 commit intoandroidx-mainfrom
Closed
Move presubmit to pull request instead of pull request target#202yigit wants to merge 1 commit intoandroidx-mainfrom
yigit wants to merge 1 commit intoandroidx-mainfrom
Conversation
This PR updates the presubmit workflow to run on pull request. It does not need the secrets anoymore since they are moved to workflow_run actions. We probably also don't need the repo checkout calculations anymore but i wanted to minimize changes. Bug: n/a Test: n/a
tikurahul
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the presubmit workflow to run on pull request.
It does not need the secrets anoymore since they are moved to
workflow_run actions.
We probably also don't need the repo checkout calculations anymore
but i wanted to minimize changes.
Bug: n/a
Test: n/a