Skip to content

Instrumented tests for InterestsListDetailScreen#1518

Merged
jdkoren merged 6 commits intomainfrom
jdk/2pane_tests
Jul 8, 2024
Merged

Instrumented tests for InterestsListDetailScreen#1518
jdkoren merged 6 commits intomainfrom
jdk/2pane_tests

Conversation

@jdkoren
Copy link
Copy Markdown
Contributor

@jdkoren jdkoren commented Jun 27, 2024

Tests for user journeys on the InterestsListDetailScreen on both single-pane and two-pane configurations. Fixes #1340

Change-Id: I0325cea93bf1e1dc0b8d1fc56434d5413caf6fea
@github-actions
Copy link
Copy Markdown

Combined test coverage report

Overall Project 41.48% 🍏

There is no coverage information present for the Files changed

Change-Id: I6246fcdd51d09a609733fd83223f6d7b8c0cb6c1
@github-actions
Copy link
Copy Markdown

Combined test coverage report

Overall Project 41.44% 🍏

There is no coverage information present for the Files changed

currentWindowAdaptiveInfo() is not affected by using the ForcedSize
override, so the list detail scaffold directve will be calculated with
non-overridden values. This work around hoists the WindowAdaptiveInfo
so that we can pass in an appropriate value in tests.

Change-Id: Ieef99f6d710ddb70243ac5105aa7805dd638ccf8
@github-actions
Copy link
Copy Markdown

Combined test coverage report

Overall Project 41.53% -0.01% 🍏
Files changed 90.7% 🍏

Module Coverage
app 30.89% -0.03% 🍏
Files
Module File Coverage
app InterestsListDetailScreen.kt 98.35% -0.41% 🍏

Change-Id: I7d8a0b3e2667ced3d73fc4f028d11823cda15455
@jdkoren jdkoren requested a review from alexvanyo June 28, 2024 20:24
Copy link
Copy Markdown
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, just some minor comments.

Also, since I think this fixes #1340, I think you can add that to the description with Fixes #1340 and once this is merged the issue will be closed automatically.

Change-Id: Iffd288c9a927f13069580c66a6ee3150abb63682
@github-actions
Copy link
Copy Markdown

Combined test coverage report

Overall Project 41.53% -0.01% 🍏
Files changed 90.7% 🍏

Module Coverage
app 30.89% -0.03% 🍏
Files
Module File Coverage
app InterestsListDetailScreen.kt 98.35% -0.41% 🍏

@jdkoren jdkoren requested a review from alexvanyo June 28, 2024 21:39
Copy link
Copy Markdown
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@android android deleted a comment from Hackermrj Jul 2, 2024
Change-Id: If336c4b9dac82382daf96284533a277cc58984fa
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2024

Combined test coverage report

Overall Project 44.75% -0.01% 🍏
Files changed 90.7% 🍏

Module Coverage
app 48.48% -0.05% 🍏
Files
Module File Coverage
app InterestsListDetailScreen.kt 98.35% -0.41% 🍏

@jdkoren jdkoren merged commit 9e4532f into main Jul 8, 2024
@jdkoren jdkoren deleted the jdk/2pane_tests branch July 8, 2024 20:27
dturner added a commit that referenced this pull request Sep 4, 2024
* main: (58 commits)
  Instrumented tests for InterestsListDetailScreen (#1518)
  Remove Firebase AD_SERVICE_CONFIG property
  updateProdReleaseBadging
  Merge Android & JVM plugins into a single `HiltConventionPlugin`
  Update dependency guard
  🤖 Updates baselines for Dependency Guard
  Update to Lifecycle 2.8.3
  Add android.adservices.AD_SERVICES_CONFIG to badges
  Apply suggestions from code review
  Update app/src/main/AndroidManifest.xml
  generateModuleGraphs
  dependencyGuardBaseline
  updateProdReleaseBadging
  Fix spotless.
  Change set to `=` operator
  Cleanup unused reference in `libs.versions.toml`
  Regenerate SVG graphs
  Update comment wording
  Use stdin to avoid repeating the output file name
  Replace bash commands with proper svgo cli
  ...

Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Testing FR] [feature:interests] Add large screen tests for 2-pane support

3 participants