Skip to content

Conversation

@gordinmitya
Copy link
Contributor

Hello, @owahltinez
I opened issue #277 so here is PR to full fill it. And as it was not only issue/question regarding YuvToRgbConverter hope this will help.

Documentation about approach, unit-tests, performance benchmarks + demo application are here https://github.com/gordinmitya/yuv2buf.

I compared performance of previous and new code on my Mi 9t pro (Snapdragon 855): old 3.5-4.0ms, new 2.6-3.0ms.
Modified CameraActivity.kt I used for comparison.

Will be happy to answer questions, if any!

@google-cla
Copy link

google-cla bot commented Dec 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gordinmitya
Copy link
Contributor Author

@googlebot I signed it!

@gordinmitya
Copy link
Contributor Author

@owahltinez could you take a look if you have time?
I would appreciate your feedback about this approach

@ggfan ggfan self-requested a review July 26, 2021 18:56
@ggfan
Copy link
Contributor

ggfan commented Jul 28, 2021

@gordinmitya could you access #399?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants