Repository navigation
Commit ed7942d
authored
lane-broker 0.42.0: node processes run with --no-maglev --no-concurrent-sparkplug (Node 24 process.exit deadlock, BRAIN-577); ships the BRAIN-576 silence watchdog (#123)
lane-broker 0.42.0. lane-broker node processes run with `--no-maglev --no-concurrent-sparkplug` (BRAIN-577). This release also ships the BRAIN-576 silence watchdog (#122).
Why: twice in an hour on the Mac's lane-broker gates, a supervisor wrote its result and then hung forever in `process.exit`. The main thread was in `NodePlatform::Shutdown` → `uv_thread_join` while a V8 worker sat in `MaglevConcurrentDispatcher::JobTask::Run` → `CollectionBarrier::AwaitCollectionBackground`. In production that means a finished lane that never returns. This is a Node 24/26 bug ([nodejs/node#64274](nodejs/node#64274); the fix [#66171](nodejs/node#66171) is unmerged), so no Node version fixes it yet. Another project measured 6/1019 hangs going to 0/1019 with both compilers off.
What changed:
- `src/node-exit-safe.js`: one flag list. `childExitSafeFlags()` is for spawned node children. They inherit `NODE_OPTIONS` but not our execArgv, so only an operator's `NODE_OPTIONS` choice suppresses a flag.
- Supervisors (`run.js`), `lane reconcile` (`status.js`) and `remote-pipeline` (`remote-runner.js`) get the flags in argv.
- The `lane` and `lane-store` CLIs disable the compilers at startup with `v8.setFlagsFromString`, as their first import. That covers code compiled after startup, but not node's bootstrap; the README notes this.
- README: a "Node runtime flags" section with the upstream links.
- Version 0.42.0.
Verified:
- `tests/node-exit-safe-flags.test.js`: a live supervisor's `ps` command line carries both flags; the operator override; a child gets both even when the parent was started with them.
- 94/94 on the spawn-path files (implementer), 10/10 targeted (orchestrator).
- Canaries: empty flag list (implementer) and the parent-execArgv filter reintroduced (orchestrator). Both failed by name and were restored.
- Push gate, full suite: ℹ tests 2202 ℹ pass 2199 fail 0. No exit deadlock this run; the BRAIN-576 gate without this fix hit it once.
Implemented-by: Sonnet
🤖 Generated with [Claude Code](https://claude.com/claude-code)1 parent 00a0dc6 commit ed7942d
11 files changed
Lines changed: 100 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2068 | 2068 | | |
2069 | 2069 | | |
2070 | 2070 | | |
| 2071 | + | |
| 2072 | + | |
| 2073 | + | |
| 2074 | + | |
| 2075 | + | |
| 2076 | + | |
| 2077 | + | |
| 2078 | + | |
| 2079 | + | |
| 2080 | + | |
| 2081 | + | |
2071 | 2082 | | |
2072 | 2083 | | |
2073 | 2084 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
564 | 565 | | |
565 | 566 | | |
566 | 567 | | |
567 | | - | |
| 568 | + | |
568 | 569 | | |
569 | 570 | | |
570 | 571 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
700 | 701 | | |
701 | 702 | | |
702 | 703 | | |
703 | | - | |
| 704 | + | |
704 | 705 | | |
705 | 706 | | |
706 | 707 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
681 | 682 | | |
682 | 683 | | |
683 | 684 | | |
684 | | - | |
| 685 | + | |
685 | 686 | | |
686 | 687 | | |
687 | 688 | | |
| |||
0 commit comments