[codex] Stabilize metric offset exporter test#177
Merged
Conversation
andrewh
marked this pull request as ready for review
June 13, 2026 11:10
andrewh
force-pushed
the
codex/fix-issue-175-metric-offset-test
branch
from
June 13, 2026 11:16
bf87f6c to
2200350
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestTimeOffsetMetricExporterEndToEndwith a manual reader collection.NewTimeOffsetMetricExportersynchronously before asserting shifted timestamps.Root cause
The test depended on
NewPeriodicReaderexporting on a background interval before the assertion loop observedrequests.count, which made the test timing-sensitive.Validation
go test ./pkg/synth -run TestTimeOffsetMetricExporterEndToEnd -count=100make testmake lintFixes issue 175.