Add scenario-aware exploration to motel check#143
Merged
Conversation
motel check now reads the scenarios block from the topology and checks every distinct combination of co-active scenarios alongside the baseline. Scenario windows are swept at their boundaries to enumerate combinations; each combination's call overrides (add_calls, remove_calls) are applied to both static analysis and sampled exploration. Each check reports the worst case and names the scenario combination that produced it, selected by static value with the sampled maximum as tie-breaker. A --skip-scenarios flag restores baseline-only checking. Closes #70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70 (part of the property-testing epic, issue 62).
motel checkpreviously analysed the topology in isolation: a topology that passes all checks could still violate bounds when a scenario adds calls or retries. It now reads thescenarios:block already present in the topology YAML — per the design discussion on the issue, no new input flags are needed.How it works
add_calls/remove_callsvia the engine's existingeffectiveCallsresolution. ExportedMaxDepth/MaxFanOut/MaxSpans/SampleTracessignatures are unchanged; they delegate to override-aware internals.CheckResult.Scenariosfield, rendered as ascenarios:annotation in the CLI output.--skip-scenariosrestores baseline-only checking, per the issue discussion.Example
Testing
ScenarioSetsenumeration (empty, overlapping windows, disjoint dedup) and forCheckattribution (scenario producing the worst case fails a tight limit and is named; baseline wins ties and call-removing scenarios)scenarios:output annotation and--skip-scenariosmake testandmake lintgreenIndependent of PR 140 — branched from main.
https://claude.ai/code/session_01TgWavXRfzQiTWDZccuS2pf
Generated by Claude Code