Support time offset for metric timestamps#141
Merged
Conversation
The OTel Metrics API does not accept caller-supplied timestamps, so --time-offset previously had no effect on metric data points. Add an exporter wrapper that rewrites StartTime, Time, and exemplar timestamps on all metricdata aggregation types before forwarding to the underlying exporter, and wire it into createMetricProviders. Closes #99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Problem
The
--time-offsetflag shifts trace span and log record timestamps, but metric data points were unaffected: the OTel Metrics API does not accept caller-supplied timestamps, so data points are stamped at collection time by the SDK'sPeriodicReader.Approach
As designed in the issue, this adds a custom exporter wrapper (
synth.NewTimeOffsetMetricExporter) that rewrites timestamps onmetricdata.ResourceMetricsbefore forwarding to the underlying exporter:StartTimeandTimeon every data point across all aggregation types:Gauge,Sum,Histogram,ExponentialHistogram(bothint64andfloat64variants), andSummarycreateMetricProvidersTests
PeriodicReaderverifying a recorded counter's data point lands within the shifted wall-clock windowmotel run --stdout --signals metrics --time-offset=-24hproduces data points stamped 24 hours in the pastAlso updates the stale "Metric timestamps are not shifted" section in the time-offset demo doc and the
--time-offsetflag help text.https://claude.ai/code/session_01TzfXWApbD3TJcKRrChdgai
Generated by Claude Code