Skip to content

Comments

workflow updates#30

Merged
andreasvc merged 1 commit intoandreasvc:masterfrom
sarnold:release-pr
May 5, 2021
Merged

workflow updates#30
andreasvc merged 1 commit intoandreasvc:masterfrom
sarnold:release-pr

Conversation

@sarnold
Copy link

@sarnold sarnold commented May 4, 2021

  • add missing sdist job to release workflow
  • add artifact check to main workflow
  • put all the artifacts in a single zip and download dir
  • bump version

@sarnold
Copy link
Author

sarnold commented May 4, 2021

Hold off on this for a bit while I check the workflows in my fork.

@sarnold sarnold changed the title add missing sdist job and artifact check to workflows, bump version workflow updates May 4, 2021
@sarnold
Copy link
Author

sarnold commented May 4, 2021

Looks good here after typo fix; go ahead and delete 0.3.5 and 0.3.6 tags, then merge PR, then make a new v0.3.6 tag and push it, and the (github) release page should pick up the v0.3.4..v0.3.6 changes.

Things to remember:

  • always use either a signed or annotated tag (lightweight tags don't work correctly with workflow versioning)
  • my own "release" flow is to merge PR changes first, then update docs as needed, then make a commit to bump the version(s) and tag that commit (somewhat cleaner than tagging a merge commit, plus it helps me remember to actually make the changes)

@andreasvc andreasvc merged commit a732777 into andreasvc:master May 5, 2021
@andreasvc
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants