Skip to content

chore: restore mirror-redirect static config (held for post-3.0.0) - #921

Merged
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:chore/restore-mirror-redirect-statics
Jun 8, 2026
Merged

chore: restore mirror-redirect static config (held for post-3.0.0)#921
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:chore/restore-mirror-redirect-statics

Conversation

@got3nks

@got3nks got3nks commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Holding queue for the two static GitHub-UI redirects that #919 explicitly removed because they'd misfire on a "Sync fork" pass into amule-org/amule (the config.yml contact link would bounce amule-org users to the page they're already on; the PR template would tell amule-org contributors "this repo is a mirror"). The follow-up note on that PR was:

After 3.0.0 ships and amule-org has its own .github/ going forward, the two static files (ISSUE_TEMPLATE/config.yml, pull_request_template.md) can be re-added to amule-project unconditionally as full-strength mirror UX — at that point the repos are intentionally divergent and there's no sync to break.

This PR is that follow-up, pre-staged in draft so it doesn't get lost.

Pre-merge checklist

Do not mark ready-for-review or merge until all boxes are ticked:

  • aMule 3.0.0 released on amule-project/amule (tag pushed, GitHub Release published).
  • amule-org/amule has its own .github/ISSUE_TEMPLATE/config.yml in place (so a Sync-fork pass from this repo doesn't silently overwrite it with our "issues moved" contact link).
  • amule-org/amule has its own .github/pull_request_template.md in place (same reason — the "this repo is a mirror" body would otherwise land on the active-fork side).
  • @mrjimenez confirms he's ready for the redirect UX to be visible to issue/PR openers on this repo.

The third condition is the one that makes the first two strictly necessary: GitHub's "Sync fork" merges new files from upstream into the fork by default. If amule-org doesn't already have its own copies of these two files when the sync hits, they propagate over and the redirect tells amule-org users to file issues at the page they're on.

What the two files do

  • .github/ISSUE_TEMPLATE/config.yml: sets blank_issues_enabled: false and surfaces a contact_link to amule-org/amule/issues in the "New issue" picker. Hard pre-emptive nudge — most users never reach /issues/new to hit the workflow-based redirect.
  • .github/pull_request_template.md: soft pre-fill of the PR description with a "this repo is a mirror" comment. Non-blocking; maintainers can clear it and proceed.

Both files are restored verbatim to their PR #915 / commit 1dea568 state. No content changes vs. what was removed in #919's d8db711.

Out of scope

The redirect-issues.yml and redirect-prs.yml workflows stay as-is on master — they're already gated by github.repository == 'amule-project/amule' so they're sync-safe regardless.

Re-introduces the two static GitHub-UI redirects that amule-project#919 removed
in d8db711 to make amule-project's .github/ safe to "Sync fork"
into amule-org/amule:

  .github/ISSUE_TEMPLATE/config.yml      -- blank_issues_enabled +
                                            contact_link to amule-org
  .github/pull_request_template.md       -- "this repo is a mirror"
                                            soft nudge prefill

Both restored verbatim to their PR amule-project#915 / commit 1dea568 state.

This PR exists in draft as the follow-up amule-project#919's body referenced:

  > After 3.0.0 ships and amule-org has its own .github/ going
  > forward, the two static files can be re-added to amule-project
  > unconditionally as full-strength mirror UX -- at that point
  > the repos are intentionally divergent and there's no sync
  > to break.

See the PR description for the pre-merge checklist (3.0.0 release
on amule-project, amule-org override files in place, maintainer
sign-off).
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

👋 Thanks for the contribution.

Heads up — this repository is a mirror. Active development happens at the project's current home: https://github.com/amule-org/amule/pulls

If you re-open this pull request against amule-org/amule it will land in front of the active reviewers right away. We're leaving this PR open here too so it isn't lost — a maintainer may merge it directly from this side if it's a small fix, but the canonical place for follow-ups, review threads, and any related issues is the new repo.

Sorry for the friction.

@got3nks
got3nks marked this pull request as ready for review June 8, 2026 09:46
@mrjimenez
mrjimenez merged commit dfcb3f0 into amule-project:master Jun 8, 2026
10 checks passed
@got3nks
got3nks deleted the chore/restore-mirror-redirect-statics branch June 8, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants