Skip to content

po: bump stale Copyright year + prune obsolete entries - #868

Merged
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:chore/po-copyright-year-bump
Jun 6, 2026
Merged

po: bump stale Copyright year + prune obsolete entries#868
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:chore/po-copyright-year-bump

Conversation

@got3nks

@got3nks got3nks commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #867 (source-code copyright header refresh) — the same year drift exists in po/*.po runtime strings. The English msgid for the About dialog is Copyright (c) 2003-2026 aMule Team, but 8 localized msgstr entries are stuck at 2003-2019 or 2003-2020. End-users in those languages see the stale year in the About box on a 2026 build.

What

  • Year bump in the About-dialog Copyright msgstr — 8 catalogs: ca, de, gl, hu, nl, sq, sv, uk.
  • Obsolete entry prune — 927 #~-marked entries across 36 catalogs (bulk in gl.po which had ~367 accumulated). msgfmt already skips obsoletes, so pruning is pure source-cleanup with no runtime effect.

Out of scope

Catalogs whose msgid itself is stale (e.g. cs.po still has msgid "Copyright (c) 2003-2019 aMule Team") are NOT updated here. Those need a routine scripts/update-po.sh sweep to msgmerge against current amule.pot, which produces a much bigger fuzzy-marker diff.

Verification

  • Re-wrapped via msgcat --width=79 so line-wrap normalisation doesn't fight the actual content diff.
  • msgfmt --check passes on all 37 catalogs.

Two complementary cleanups on po/*.po:

(1) Bump stale year in the About-dialog Copyright msgstr — 8
    catalogs (ca, de, gl, hu, nl, sq, sv, uk) had translators
    bump the year to 2019/2020 and stop. The English msgid is
    already at 2003-2026; the localized runtime line at the
    bottom of the About dialog now matches.

(2) Drop accumulated obsolete (#~) entries — 927 stale entries
    across 36 catalogs (gl alone had 367, the rest 1-22 each).
    These were obsolete msgid/msgstr pairs that msgmerge kept
    as translator hints when source strings changed; msgfmt
    skips them already, so pruning is a pure source-cleanup
    with no runtime effect.

Catalogs whose msgid itself is stale (e.g. cs.po still has
"Copyright (c) 2003-2019 aMule Team" as msgid, never msgmerge'd
against current amule.pot) are NOT addressed here — those need
a routine scripts/update-po.sh sweep, which is a much bigger
diff (fuzzy markers across many languages) and out of scope.

Re-wrapped via msgcat --width=79 so the diff stays focused on
content. msgfmt --check passes on all 37 catalogs.
@got3nks
got3nks marked this pull request as draft June 6, 2026 09:43
@got3nks
got3nks marked this pull request as ready for review June 6, 2026 09:50
@mrjimenez
mrjimenez merged commit ef39553 into amule-project:master Jun 6, 2026
7 checks passed
got3nks added a commit to got3nks/amule that referenced this pull request Jun 7, 2026
…ule-project#912)

Extends existing categories (preferring extensions over new lines):
- Performance/Upload: amule-project#898 SlotAllocation default raised.
- Networking & Discovery: wire-parser hardening list extended with
  amule-project#879/amule-project#882/amule-project#890/amule-project#886; new amuleweb security hardening bullet
  consolidating ngosang's amule-project#869-amule-project#874 triage (all landed in amule-project#875);
  amulegui list extended with amule-project#857; shared-folder watcher extended
  with amule-project#858.
- Packaging: Windows installer i18n line extended with amule-project#899.
- Internals & Refactoring: new docs-polish + code-quality bullets
  covering amule-project#851/amule-project#855/amule-project#862/amule-project#888/amule-project#900/amule-project#866/amule-project#867/amule-project#895 and amule-project#909/amule-project#910/amule-project#912.
- Translations: new pre-release final-wave bullet covering amule-project#847/amule-project#856/
  amule-project#891/amule-project#908/amule-project#860/amule-project#904/amule-project#859/amule-project#863/amule-project#861/amule-project#880/amule-project#911/amule-project#901/amule-project#902/amule-project#889/amule-project#868/amule-project#853.
- Bug Fixes & Stability: amule-project#850/amule-project#854/amule-project#878/amule-project#906.
- CI: ccache wiring (amule-project#892, amule-project#903) + CodeQL binutils-dev (amule-project#907).

Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif
(both first-time contributors).

PR index extended through amule-project#912.
mrjimenez pushed a commit that referenced this pull request Jun 8, 2026
Extends existing categories (preferring extensions over new lines):
- Performance/Upload: #898 SlotAllocation default raised.
- Networking & Discovery: wire-parser hardening list extended with
  #879/#882/#890/#886; new amuleweb security hardening bullet
  consolidating ngosang's #869-#874 triage (all landed in #875);
  amulegui list extended with #857; shared-folder watcher extended
  with #858.
- Packaging: Windows installer i18n line extended with #899.
- Internals & Refactoring: new docs-polish + code-quality bullets
  covering #851/#855/#862/#888/#900/#866/#867/#895 and #909/#910/#912.
- Translations: new pre-release final-wave bullet covering #847/#856/
  #891/#908/#860/#904/#859/#863/#861/#880/#911/#901/#902/#889/#868/#853.
- Bug Fixes & Stability: #850/#854/#878/#906.
- CI: ccache wiring (#892, #903) + CodeQL binutils-dev (#907).

Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif
(both first-time contributors).

PR index extended through #912.
@got3nks
got3nks deleted the chore/po-copyright-year-bump branch June 8, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants