Skip to content

chore: refresh aMule Team copyright header across the source tree (#865) - #867

Merged
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:chore/refresh-copyright-header
Jun 6, 2026
Merged

chore: refresh aMule Team copyright header across the source tree (#865)#867
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:chore/refresh-copyright-header

Conversation

@got3nks

@got3nks got3nks commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

#865 (cardpuncher) — the institutional aMule Team copyright header is still wired to the dead [email protected] mailbox and the old http://www.amule.org website. Unify every occurrence to the single canonical line, normalised on a 2003-2026 year range:

// Copyright (c) 2003-2026 aMule Team ( https://amule-org.github.io )

The original comment prefix (//, #, ##, *, plain) is preserved verbatim.

Scope

  • 427 files, 431 line replacements.
  • Per-contributor personal copyrights (Marcelo Roberto Jimenez [email protected], Dévai Tamás [email protected], Patrizio Bassi [email protected], Angel Vidal [email protected], Kry [email protected]) — NOT touched. ~105 lines remain intact; those use personal email addresses and bumping is for the named contributor to decide.
  • Special casesrc/LibSocket.h / src/LibSocketAsio.cpp carry a Stu Redman copyright that used the team admin email rather than a personal one. Refreshed the URL and bumped the year while preserving Stu's name.
  • Script sidesrc/utils/scripts/version_bumper echoes a copyright header when generating new files; updated so newly-bumped files get the new convention.

Closes #865.

amule-project#865 reported the stale header still in 425+ source files:

  // Copyright (c) <year>-<year> aMule Team ( [email protected] / http://www.amule.org )

The team email ([email protected]) is dead and the website moved
to https://amule-org.github.io with the migration to GitHub.
Unify every "aMule Team" attribution to the single canonical
line, normalised on a 2003-2026 range:

  // Copyright (c) 2003-2026 aMule Team ( https://amule-org.github.io )

Comment prefix (// for C/C++, # for shell/Python, ## for some
scripts, * for block comments, plain for text) preserved
verbatim.

Also touched:
- src/utils/scripts/version_bumper — same echo'd line refresh
  so freshly-bumped files get the new convention.
- src/LibSocket.h / src/LibSocketAsio.cpp — Stu Redman's
  per-file copyright also used the dead [email protected]
  address; refreshed his line's URL and bumped the year to
  2026 while preserving his name.

Per-contributor personal copyrights (Marcelo Roberto Jimenez,
Dévai Tamás, Patrizio Bassi, Angel Vidal, Kry — ~105 lines
total) are intentionally NOT touched. Those use personal email
addresses and bumping them is for the named contributor to
decide.

Closes amule-project#865.
@got3nks
got3nks force-pushed the chore/refresh-copyright-header branch from c0fbca7 to 2d1d430 Compare June 6, 2026 09:20
@mrjimenez
mrjimenez merged commit 2187772 into amule-project:master Jun 6, 2026
7 checks passed
got3nks added a commit to got3nks/amule that referenced this pull request Jun 7, 2026
…ule-project#912)

Extends existing categories (preferring extensions over new lines):
- Performance/Upload: amule-project#898 SlotAllocation default raised.
- Networking & Discovery: wire-parser hardening list extended with
  amule-project#879/amule-project#882/amule-project#890/amule-project#886; new amuleweb security hardening bullet
  consolidating ngosang's amule-project#869-amule-project#874 triage (all landed in amule-project#875);
  amulegui list extended with amule-project#857; shared-folder watcher extended
  with amule-project#858.
- Packaging: Windows installer i18n line extended with amule-project#899.
- Internals & Refactoring: new docs-polish + code-quality bullets
  covering amule-project#851/amule-project#855/amule-project#862/amule-project#888/amule-project#900/amule-project#866/amule-project#867/amule-project#895 and amule-project#909/amule-project#910/amule-project#912.
- Translations: new pre-release final-wave bullet covering amule-project#847/amule-project#856/
  amule-project#891/amule-project#908/amule-project#860/amule-project#904/amule-project#859/amule-project#863/amule-project#861/amule-project#880/amule-project#911/amule-project#901/amule-project#902/amule-project#889/amule-project#868/amule-project#853.
- Bug Fixes & Stability: amule-project#850/amule-project#854/amule-project#878/amule-project#906.
- CI: ccache wiring (amule-project#892, amule-project#903) + CodeQL binutils-dev (amule-project#907).

Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif
(both first-time contributors).

PR index extended through amule-project#912.
mrjimenez pushed a commit that referenced this pull request Jun 8, 2026
Extends existing categories (preferring extensions over new lines):
- Performance/Upload: #898 SlotAllocation default raised.
- Networking & Discovery: wire-parser hardening list extended with
  #879/#882/#890/#886; new amuleweb security hardening bullet
  consolidating ngosang's #869-#874 triage (all landed in #875);
  amulegui list extended with #857; shared-folder watcher extended
  with #858.
- Packaging: Windows installer i18n line extended with #899.
- Internals & Refactoring: new docs-polish + code-quality bullets
  covering #851/#855/#862/#888/#900/#866/#867/#895 and #909/#910/#912.
- Translations: new pre-release final-wave bullet covering #847/#856/
  #891/#908/#860/#904/#859/#863/#861/#880/#911/#901/#902/#889/#868/#853.
- Bug Fixes & Stability: #850/#854/#878/#906.
- CI: ccache wiring (#892, #903) + CodeQL binutils-dev (#907).

Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif
(both first-time contributors).

PR index extended through #912.
@got3nks
got3nks deleted the chore/refresh-copyright-header branch June 8, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

References to the old website in the source code

2 participants