fix(amule): refresh stale --enable-webserver build hint in amuleweb-launch failure (#864) - #866
Merged
mrjimenez merged 2 commits intoJun 6, 2026
Conversation
…aunch failure (amule-project#864) The user-facing modal that fires when the "Run web server on startup" preference is enabled but amuleweb cannot be exec'd suggested the autotools build recipe: ...or compile aMule using --enable-webserver and run make install aMule has moved to CMake; the source-build half of that hint should now read: ...or build aMule from source with -DBUILD_WEBSERVER=YES and install it. Updated src/amule.cpp and po/amule.pot only. po/*.po will be refreshed on the next routine update-po.sh sweep; translators will pick up the fuzzy entry then. Localized installs render the English source string for this one message in the intervening window — same fallback they would get if msgmerge were run today (msgfmt skips fuzzy entries from .mo). Reported by @cardpuncher in amule-project#864.
… pages (amule-project#864) Stoatwblr's grep on amule-project#864 turned up two more sites carrying the same autotools-era hint as the amuleweb-launch failure that the previous commit refreshed: - src/webserver/src/WebServer.cpp:2008 The inline "missing template" error page emitted by amuleweb when the configured templates directory is empty/wrong. The hint told source builders to run `make` + `make install`. - src/webserver/src/missing-template.html:14 The standalone HTML version of the same error, used when amuleweb can find the templates dir but the specific template file is missing. Same stale `make install` text. Replace the autotools commands with the CMake equivalents (`cmake --build build`, `cmake --install build`) so the help text matches what a contemporary source build actually looks like. Both strings are raw HTML string literals -- not `_()`-wrapped -- so they don't appear in the gettext catalog and no `.po` / `.pot` regeneration is needed.
got3nks
force-pushed
the
fix/webserver-error-cmake-build-flag
branch
from
June 6, 2026 11:55
d27cf1e to
18fac0c
Compare
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jun 7, 2026
…ule-project#912) Extends existing categories (preferring extensions over new lines): - Performance/Upload: amule-project#898 SlotAllocation default raised. - Networking & Discovery: wire-parser hardening list extended with amule-project#879/amule-project#882/amule-project#890/amule-project#886; new amuleweb security hardening bullet consolidating ngosang's amule-project#869-amule-project#874 triage (all landed in amule-project#875); amulegui list extended with amule-project#857; shared-folder watcher extended with amule-project#858. - Packaging: Windows installer i18n line extended with amule-project#899. - Internals & Refactoring: new docs-polish + code-quality bullets covering amule-project#851/amule-project#855/amule-project#862/amule-project#888/amule-project#900/amule-project#866/amule-project#867/amule-project#895 and amule-project#909/amule-project#910/amule-project#912. - Translations: new pre-release final-wave bullet covering amule-project#847/amule-project#856/ amule-project#891/amule-project#908/amule-project#860/amule-project#904/amule-project#859/amule-project#863/amule-project#861/amule-project#880/amule-project#911/amule-project#901/amule-project#902/amule-project#889/amule-project#868/amule-project#853. - Bug Fixes & Stability: amule-project#850/amule-project#854/amule-project#878/amule-project#906. - CI: ccache wiring (amule-project#892, amule-project#903) + CodeQL binutils-dev (amule-project#907). Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif (both first-time contributors). PR index extended through amule-project#912.
mrjimenez
pushed a commit
that referenced
this pull request
Jun 8, 2026
Extends existing categories (preferring extensions over new lines): - Performance/Upload: #898 SlotAllocation default raised. - Networking & Discovery: wire-parser hardening list extended with #879/#882/#890/#886; new amuleweb security hardening bullet consolidating ngosang's #869-#874 triage (all landed in #875); amulegui list extended with #857; shared-folder watcher extended with #858. - Packaging: Windows installer i18n line extended with #899. - Internals & Refactoring: new docs-polish + code-quality bullets covering #851/#855/#862/#888/#900/#866/#867/#895 and #909/#910/#912. - Translations: new pre-release final-wave bullet covering #847/#856/ #891/#908/#860/#904/#859/#863/#861/#880/#911/#901/#902/#889/#868/#853. - Bug Fixes & Stability: #850/#854/#878/#906. - CI: ccache wiring (#892, #903) + CodeQL binutils-dev (#907). Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif (both first-time contributors). PR index extended through #912.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/amule.cpp:850— the modal shown when the "Run web server on startup" preference is on but theamulewebchild process fails to launch — embedded the autotools build instruction:That recipe predates the move to CMake. Replaced with the current CMake equivalent:
Scope
src/amule.cpp— source string updatedpo/amule.pot— same msgid block + POT-Creation-Date refreshedpo/*.po— not touched in this PRThe
.poregen is intentionally deferred to the nextscripts/update-po.shsweep so translators see the change as a single coordinated fuzzy refresh. Until then, localized installs render this one message in English (msgfmtskips fuzzy entries from.mo, so a msgmerge sweep today would produce the same runtime fallback).Fixes #864.