Skip to content

docs: point IRC channel to irc.libera.chat (#696) - #855

Merged
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:fix/freenode-to-libera
Jun 5, 2026
Merged

docs: point IRC channel to irc.libera.chat (#696)#855
mrjimenez merged 1 commit into
amule-project:masterfrom
got3nks:fix/freenode-to-libera

Conversation

@got3nks

@got3nks got3nks commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Replace irc.freenode.net with irc.libera.chat in the live About-dialog string at src/amule.cpp:1260, regenerate po/amule.pot, and sweep the hostname inside every msgstr that copied it verbatim so the existing translations stay accurate (no fuzzy markers introduced).

Per the discussion in #696: the freenode #amule channel is empty, libera's is active. CHANGELOG entries crediting 2003-era contributors at #wxwidgets / #gentoo on freenode are left as-is — those are historical credits to a different community, not a live recommendation.

Test plan

  • On a fresh config, run amule; the About-dialog "More information" text shows irc.libera.chat.
  • msgfmt --check passes on all 37 .po files locally (only amule.pot shows the expected template-default warnings, identical to master).

Closes #696

The freenode network is effectively defunct since the 2021 ownership
change; the #amule channel has moved to irc.libera.chat (same name,
@sc0w is in it). Update the live source string referenced by the
About-dialog "More information" path, regenerate po/amule.pot, and
swap the verbatim hostname in every translated msgstr that carried
the old name.

CHANGELOG entries crediting 2003-era contributors at #wxwidgets /
#gentoo on freenode are left as-is; those are historical credits
to a different community, not a live recommendation.
@mrjimenez
mrjimenez merged commit 611faa0 into amule-project:master Jun 5, 2026
7 checks passed
@got3nks
got3nks deleted the fix/freenode-to-libera branch June 5, 2026 22:35
got3nks added a commit to got3nks/amule that referenced this pull request Jun 7, 2026
…ule-project#912)

Extends existing categories (preferring extensions over new lines):
- Performance/Upload: amule-project#898 SlotAllocation default raised.
- Networking & Discovery: wire-parser hardening list extended with
  amule-project#879/amule-project#882/amule-project#890/amule-project#886; new amuleweb security hardening bullet
  consolidating ngosang's amule-project#869-amule-project#874 triage (all landed in amule-project#875);
  amulegui list extended with amule-project#857; shared-folder watcher extended
  with amule-project#858.
- Packaging: Windows installer i18n line extended with amule-project#899.
- Internals & Refactoring: new docs-polish + code-quality bullets
  covering amule-project#851/amule-project#855/amule-project#862/amule-project#888/amule-project#900/amule-project#866/amule-project#867/amule-project#895 and amule-project#909/amule-project#910/amule-project#912.
- Translations: new pre-release final-wave bullet covering amule-project#847/amule-project#856/
  amule-project#891/amule-project#908/amule-project#860/amule-project#904/amule-project#859/amule-project#863/amule-project#861/amule-project#880/amule-project#911/amule-project#901/amule-project#902/amule-project#889/amule-project#868/amule-project#853.
- Bug Fixes & Stability: amule-project#850/amule-project#854/amule-project#878/amule-project#906.
- CI: ccache wiring (amule-project#892, amule-project#903) + CodeQL binutils-dev (amule-project#907).

Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif
(both first-time contributors).

PR index extended through amule-project#912.
mrjimenez pushed a commit that referenced this pull request Jun 8, 2026
Extends existing categories (preferring extensions over new lines):
- Performance/Upload: #898 SlotAllocation default raised.
- Networking & Discovery: wire-parser hardening list extended with
  #879/#882/#890/#886; new amuleweb security hardening bullet
  consolidating ngosang's #869-#874 triage (all landed in #875);
  amulegui list extended with #857; shared-folder watcher extended
  with #858.
- Packaging: Windows installer i18n line extended with #899.
- Internals & Refactoring: new docs-polish + code-quality bullets
  covering #851/#855/#862/#888/#900/#866/#867/#895 and #909/#910/#912.
- Translations: new pre-release final-wave bullet covering #847/#856/
  #891/#908/#860/#904/#859/#863/#861/#880/#911/#901/#902/#889/#868/#853.
- Bug Fixes & Stability: #850/#854/#878/#906.
- CI: ccache wiring (#892, #903) + CodeQL binutils-dev (#907).

Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif
(both first-time contributors).

PR index extended through #912.
mrjimenez pushed a commit to mrjimenez/amule that referenced this pull request Aug 8, 2026
…endored wxGenericListCtrl (amule-project#855)

Follow-up to amule-project#801/amule-project#180: with the client-list port done in amule-project#850, CCommentDialogLst was the only remaining instantiator of CMuleListCtrl and CMuleVirtualListCtrl had no derivers left.

CCommentDialogLst drops to a plain wxListCtrl -- a small read-only modal list that does not warrant the CMuleDataViewCtrl treatment -- with click-to-sort reimplemented by hand. amuleDlg's exit-time SaveListControlSettings() widget walk goes too: it existed because CMuleListCtrl only saved lazily from its destructor, which the tray-Exit path could skip, whereas CMuleDataViewCtrl writes column widths and sort orders eagerly on every resize, sort and show/hide, and SaveGUIPrefs() still flushes on every close path.

That leaves CMuleVirtualListCtrl, CMuleListCtrl and the vendored wxGenericListCtrl with no consumers, so all four files are deleted. IsListBackgroundDark() moves to MuleColour.h. CListColumnStore's legacy config-migration path is untouched -- it still reads pre-dataview TableWidths* entries.

One known simplification: the comments dialog loses its header sort-arrow glyph, which plain wxListCtrl does not draw. A follow-up restores it via ShowSortIndicator().
mrjimenez pushed a commit to mrjimenez/amule that referenced this pull request Aug 8, 2026
…st (amule-project#857)

Two gaps in the comments/ratings dialog, plus one piece of dead code found alongside them.

The sort caret went with amule-project#855's downgrade from CMuleListCtrl to a plain wxListCtrl, which tracks no sort state of its own; ShowSortIndicator() drives the glyph explicitly, and all three ports draw it -- macOS and GTK through the generic implementation, Windows through wxMSW's override.

The rating smiley was never there, on master either: the column has always been GetRateString() text alone while every other list showing a rating draws the icon beside it. The images are already in the app's shared list, so it needs SetImageList() plus a per-row SetItemColumnImage(). Borrowed rather than assigned, so this modal does not delete the app's list on close. Unrated rows stay blank rather than drawing a "not rated" glyph on each one.

The cell also fell back to an untranslated "on" for a rating of -1, which cannot occur: the wire value is a uint8 and CUpDownClient clamps anything above 5 to 0, so the range is 0..5 with 0 meaning a comment carrying no rating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace freenode irc mentions with libera.chat

2 participants