docs(kademlia): refresh Petar Maymounkov's email and paper URL to current - #851
Merged
mrjimenez merged 1 commit intoJun 4, 2026
Merged
Conversation
…rent The About box and three kademlia source-file copyright headers carried the 2002-era post.harvard.edu email and the long-defunct http://kademlia.scs.cs.nyu.edu page. Petar Maymounkov confirmed his current address and a durable canonical URL for the paper on amule-project#838: email: [email protected] -> [email protected] url: http://kademlia.scs.cs.nyu.edu -> https://pdos.csail.mit.edu/~petar/papers/maymounkov-kademlia-lncs.pdf Updated in five spots: - src/amuleDlg.cpp:533-534 (user-visible About box text) - src/kademlia/routing/Contact.cpp:24-25 - src/kademlia/routing/RoutingBin.cpp:24-25 - src/kademlia/routing/RoutingZone.cpp:25-26 Closes amule-project#838.
3 tasks
mrjimenez
pushed a commit
that referenced
this pull request
Jun 5, 2026
PR #851 updated [email protected] -> [email protected] and the NYU URL -> the MIT CSAIL paper URL in src/amuleDlg.cpp:533-534, but the po/*.po files still carried the old strings in both msgid and msgstr. After #851 landed they were stale — translators would have ended up re-translating identical text just because the email/URL changed. Direct sed substitution across msgid AND msgstr in every .po + the .pot preserves every existing translation untouched (the surrounding "Copyright (c) ... Petar Maymounkov" wording stays in whatever language it was already in) and brings the catalogs into sync with the source in one mechanical pass — no obsolete entries, no fuzzy markers, no manual re-translation. scripts/update-po.sh then re-ran cleanly on top (just POT-Creation-Date + line-number realignment from a few days of drift). msgfmt --check passes on every .po file.
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jun 7, 2026
…ule-project#912) Extends existing categories (preferring extensions over new lines): - Performance/Upload: amule-project#898 SlotAllocation default raised. - Networking & Discovery: wire-parser hardening list extended with amule-project#879/amule-project#882/amule-project#890/amule-project#886; new amuleweb security hardening bullet consolidating ngosang's amule-project#869-amule-project#874 triage (all landed in amule-project#875); amulegui list extended with amule-project#857; shared-folder watcher extended with amule-project#858. - Packaging: Windows installer i18n line extended with amule-project#899. - Internals & Refactoring: new docs-polish + code-quality bullets covering amule-project#851/amule-project#855/amule-project#862/amule-project#888/amule-project#900/amule-project#866/amule-project#867/amule-project#895 and amule-project#909/amule-project#910/amule-project#912. - Translations: new pre-release final-wave bullet covering amule-project#847/amule-project#856/ amule-project#891/amule-project#908/amule-project#860/amule-project#904/amule-project#859/amule-project#863/amule-project#861/amule-project#880/amule-project#911/amule-project#901/amule-project#902/amule-project#889/amule-project#868/amule-project#853. - Bug Fixes & Stability: amule-project#850/amule-project#854/amule-project#878/amule-project#906. - CI: ccache wiring (amule-project#892, amule-project#903) + CodeQL binutils-dev (amule-project#907). Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif (both first-time contributors). PR index extended through amule-project#912.
mrjimenez
pushed a commit
that referenced
this pull request
Jun 8, 2026
Extends existing categories (preferring extensions over new lines): - Performance/Upload: #898 SlotAllocation default raised. - Networking & Discovery: wire-parser hardening list extended with #879/#882/#890/#886; new amuleweb security hardening bullet consolidating ngosang's #869-#874 triage (all landed in #875); amulegui list extended with #857; shared-folder watcher extended with #858. - Packaging: Windows installer i18n line extended with #899. - Internals & Refactoring: new docs-polish + code-quality bullets covering #851/#855/#862/#888/#900/#866/#867/#895 and #909/#910/#912. - Translations: new pre-release final-wave bullet covering #847/#856/ #891/#908/#860/#904/#859/#863/#861/#880/#911/#901/#902/#889/#868/#853. - Bug Fixes & Stability: #850/#854/#878/#906. - CI: ccache wiring (#892, #903) + CodeQL binutils-dev (#907). Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif (both first-time contributors). PR index extended through #912.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #838.
Why
The About box and three kademlia source-file copyright headers carried the 2002-era
[email protected]email and the long-defuncthttp://kademlia.scs.cs.nyu.edupage (NYU page returns 404). @petar replied on #838 confirming his current address and the canonical URLs for the paper:Picked the MIT CSAIL paper page since it's on Petar's own page (the Stanford mirror is on collaborator David Mazières' page — same paper, just hosted by someone else).
What
Updated in five spots:
src/amuleDlg.cpp:533-534— user-visible About box textsrc/kademlia/routing/Contact.cpp:24-25— file-header copyrightsrc/kademlia/routing/RoutingBin.cpp:24-25src/kademlia/routing/RoutingZone.cpp:25-26Both fields:
[email protected]→[email protected]http://kademlia.scs.cs.nyu.edu→https://pdos.csail.mit.edu/~petar/papers/maymounkov-kademlia-lncs.pdfFollow-up (separate)
@ngosang suggested also mirroring the paper at
amule-org.github.io/staticfor long-term insurance against academic-page link rot. That's a sensible follow-up on the website repo — independent of this PR.