pre-release(3.0.0): refresh CHANGELOG with post-#747 wave + regenerate .po translations - #846
Merged
mrjimenez merged 2 commits intoJun 4, 2026
Conversation
13 tasks
got3nks
force-pushed
the
docs/changelog-bump-pre-3.0.0
branch
from
June 4, 2026 14:23
3e903a2 to
ca6b1a3
Compare
…ndex Adds 55+ merged PRs to the 3.0.0 changelog since the last update (amule-project#747, 2026-05-27). Narrative additions cover: - Packaging: expanded the top list to include the macOS per-arch .app bundles and the Windows NSIS installer alongside the existing AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785 (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796 (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths). - Bug Fixes & Stability: post-amule-project#744 fixes including EC notification leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728), amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760), PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788, amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756), Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833, amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774). - Translations: late-cycle wave covering French/Turkish manpages (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for date+version drift (amule-project#802). - Contributors: added ngosang for UX feedback on the late-3.0 cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the user-facing manual at amule-org.github.io. - Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.
Captures translatable strings introduced after the previous po refresh (post-amule-project#747 wave). Notable new entries: - "Connection failed. Please check the host, port, and password." (amule-project#841 — amulegui retry-on-connect-failure) - "Force ZLIB compression" (amule-project#840 — EC client-tag locality override) - "Follow symbolic links in shared folders" (amule-project#809) - "Connection Type:" (amule-project#824 — ED2K Info readability) - "Documentation: https://amule-org.github.io/docs " (amule-project#801 — wiki URL migration) Generated with `scripts/update-po.sh` from a working tree that has PR amule-project#841 applied locally, so the new amulegui retry-loop strings are included even though amule-project#841 itself is not in this branch — when amule-project#841 lands on master, the .po files will already reflect its strings without needing a second regeneration pass. The remaining churn is line-number realignment across the ~38 language files from a month of source-code drift.
got3nks
force-pushed
the
docs/changelog-bump-pre-3.0.0
branch
from
June 4, 2026 14:33
ca6b1a3 to
434f52b
Compare
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jun 7, 2026
…ule-project#912) Extends existing categories (preferring extensions over new lines): - Performance/Upload: amule-project#898 SlotAllocation default raised. - Networking & Discovery: wire-parser hardening list extended with amule-project#879/amule-project#882/amule-project#890/amule-project#886; new amuleweb security hardening bullet consolidating ngosang's amule-project#869-amule-project#874 triage (all landed in amule-project#875); amulegui list extended with amule-project#857; shared-folder watcher extended with amule-project#858. - Packaging: Windows installer i18n line extended with amule-project#899. - Internals & Refactoring: new docs-polish + code-quality bullets covering amule-project#851/amule-project#855/amule-project#862/amule-project#888/amule-project#900/amule-project#866/amule-project#867/amule-project#895 and amule-project#909/amule-project#910/amule-project#912. - Translations: new pre-release final-wave bullet covering amule-project#847/amule-project#856/ amule-project#891/amule-project#908/amule-project#860/amule-project#904/amule-project#859/amule-project#863/amule-project#861/amule-project#880/amule-project#911/amule-project#901/amule-project#902/amule-project#889/amule-project#868/amule-project#853. - Bug Fixes & Stability: amule-project#850/amule-project#854/amule-project#878/amule-project#906. - CI: ccache wiring (amule-project#892, amule-project#903) + CodeQL binutils-dev (amule-project#907). Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif (both first-time contributors). PR index extended through amule-project#912.
mrjimenez
pushed a commit
that referenced
this pull request
Jun 8, 2026
Extends existing categories (preferring extensions over new lines): - Performance/Upload: #898 SlotAllocation default raised. - Networking & Discovery: wire-parser hardening list extended with #879/#882/#890/#886; new amuleweb security hardening bullet consolidating ngosang's #869-#874 triage (all landed in #875); amulegui list extended with #857; shared-folder watcher extended with #858. - Packaging: Windows installer i18n line extended with #899. - Internals & Refactoring: new docs-polish + code-quality bullets covering #851/#855/#862/#888/#900/#866/#867/#895 and #909/#910/#912. - Translations: new pre-release final-wave bullet covering #847/#856/ #891/#908/#860/#904/#859/#863/#861/#880/#911/#901/#902/#889/#868/#853. - Bug Fixes & Stability: #850/#854/#878/#906. - CI: ccache wiring (#892, #903) + CodeQL binutils-dev (#907). Contributors footer gains mifritscher and nguyenhoangminhhieu2004-gif (both first-time contributors). PR index extended through #912.
mrjimenez
pushed a commit
to mrjimenez/amule
that referenced
this pull request
Aug 8, 2026
…ule-project#846) RegisterColumn() kept its registry sorted by index and then renumbered every entry after an insert. The loop incremented its iterator before dereferencing, so the displaced entry was skipped, and on its final pass it stepped to end() and wrote through the sentinel. It never fired: every caller registers in ascending order, which leaves the search at end() and the loop a no-op. Renumbering is not repairable either, because the wxDataViewCtrl lists key on stable column ids while the legacy wxListCtrl lists key on the column position, so no single behaviour suits both. Neither family inserts mid-list, so the loop goes and the plain sorted insert stays. A duplicate index is no longer masked by the shift, so it now asserts in Debug beside the existing name-uniqueness check. Adds ListColumnStoreTest, which pins the registry contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, both targeting the 3.0 prep cycle:
docs(changelog): cover post-#747 wave + extend flat PR indexAdds ~55 merged PRs to the 3.0.0 changelog (since #747, 2026-05-27).
.appbundles and Windows NSIS installer alongside AppImage / Flatpak /.dmg/ portable.zip..dmgamuleweb path fix), packaging: standardise release-asset filenames around <OS>-<arch> naming #789 (<OS>-<arch>artifact naming), fix(windows): declare PerMonitorV2 DPI awareness so the GUI isn't bitmap-scaled at non-100% scaling #780 / fix(windows): embed comctl32 v6 + PerMonitorV2 manifest in alc and wxcas #796 (Windows DPI + comctl32 manifest), fix(windows): resolve skin / webserver template dir to FHS share/amule path #784 (FHS share/amule paths).remote.confsettings are read but never written back (ZLIB,PageRefreshTime) #817, Inconsistent section capitalization for web server UPnP keys:[Webserver]vs[WebServer]inremote.conf#818, Inconsistent default for/EC/Hostinremote.conf: empty (amulecmd/amuleweb) vslocalhost(amulegui) #821, Error in amuleweb: Cannot find template: default #828, enhancement: geoIP #844) and ongoing work on the user-facing manual at https://amule-org.github.io.po: regenerate amule.pot and msgmerge into all .po filesRuns
scripts/update-po.shto refreshpo/amule.potand msgmerge into everypo/*.po. Notable new translatable strings:"Force ZLIB compression"(#840),"Follow symbolic links in shared folders"(#809),"Connection Type:"(#824), the wiki-URL migration (#801), and"Connection failed. Please check the host, port, and password."(#841 — included even though #841 itself isn't in this branch, generated from a working tree with #841 applied; once #841 merges the .po files will already reflect its strings).Remaining churn is line-number realignment from a month of source-code drift across the ~38 language files.
Tasks
.poregen and the changelog Bug Fixes bullet reference strings / behaviour introduced by amulegui: re-show connection dialog on connect failure instead of quitting #841. Land amulegui: re-show connection dialog on connect failure instead of quitting #841, then rebase this branch onto master before merging.