revert: undo wxSize floor + sizer swap on preferences sliders (slider invisibility on wxGTK 3.2.9) - #836
Merged
mrjimenez merged 2 commits intoJun 3, 2026
Conversation
got3nks
marked this pull request as draft
June 3, 2026 12:46
got3nks
force-pushed
the
fix/preferences-advanced-slider-minsize
branch
from
June 3, 2026 13:25
3440f8b to
fa72072
Compare
got3nks
changed the title
Contributor
Author
|
Force-pushed: the PR's content is now a clean revert of the two commits that turned out to be the actual regression source rather than the SetMinSize attempt I'd opened it with. Verified on a clean Ubuntu ARM64 VM (wxGTK 3.2.9): with both reverts applied, sliders render correctly on Statistics + Advanced tabs, and stderr is silent — no GTK warnings of any kind. Same checks fail on every build between Bisect breadcrumb for anyone reviewing: rolled back 245 commits to |
got3nks
marked this pull request as ready for review
June 3, 2026 13:26
1 task
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jun 4, 2026
…ndex Adds 55+ merged PRs to the 3.0.0 changelog since the last update (amule-project#747, 2026-05-27). Narrative additions cover: - Packaging: expanded the top list to include the macOS per-arch .app bundles and the Windows NSIS installer alongside the existing AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785 (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796 (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths). - Bug Fixes & Stability: post-amule-project#744 fixes including EC notification leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728), amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760), PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788, amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756), Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833, amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774). - Translations: late-cycle wave covering French/Turkish manpages (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for date+version drift (amule-project#802). - Contributors: added ngosang for UX feedback on the late-3.0 cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the user-facing manual at amule-org.github.io. - Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jun 4, 2026
…ndex Adds 55+ merged PRs to the 3.0.0 changelog since the last update (amule-project#747, 2026-05-27). Narrative additions cover: - Packaging: expanded the top list to include the macOS per-arch .app bundles and the Windows NSIS installer alongside the existing AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785 (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796 (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths). - Bug Fixes & Stability: post-amule-project#744 fixes including EC notification leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728), amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760), PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788, amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756), Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833, amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774). - Translations: late-cycle wave covering French/Turkish manpages (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for date+version drift (amule-project#802). - Contributors: added ngosang for UX feedback on the late-3.0 cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the user-facing manual at amule-org.github.io. - Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.
mrjimenez
pushed a commit
that referenced
this pull request
Jun 4, 2026
Adds 55+ merged PRs to the 3.0.0 changelog since the last update (#747, 2026-05-27). Narrative additions cover: - Packaging: expanded the top list to include the macOS per-arch .app bundles and the Windows NSIS installer alongside the existing AppImage / Flatpak / .dmg / .zip entries. New bullets for #785 (alc/alcc/cas/wxcas everywhere + Windows amuleweb), #794 (.dmg amuleweb path), #789 (<OS>-<arch> artifact naming), #780 / #796 (Windows DPI + comctl32 manifest), #784 (FHS share/amule paths). - Bug Fixes & Stability: post-#744 fixes including EC notification leak (#797), big-library scaling (#736, #840 superseding #728), amulegui ghost entries (#810, #819, #841, #824, #830, #760), PartFile early hash (#762), server protocol fixes (#835, #788, #721, #787), crypto stream UB (#779), UAF prevention (#756), Kad rotation (#795, #799/#805), GTK warning silencing (#833, #826/#836), and the clang-tidy worklist (#770, #772-#774). - Translations: late-cycle wave covering French/Turkish manpages (#753/#754/#776), Galician (#763), Slovenian (#771), pt-BR (#768/#775/#812), French (#811), plus man-page tooling for date+version drift (#802). - Contributors: added ngosang for UX feedback on the late-3.0 cycle (#817/#818/#821/#828/#844) and ongoing work on the user-facing manual at amule-org.github.io. - Merged PRs flat index: extended with #746-#845 + #841.
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Aug 7, 2026
…-application Translations update from Weblate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts two recent preferences-slider commits that turned out to introduce a real UI regression on wxGTK 3.2.9 (sliders invisible on Statistics + Advanced tabs) while trying to silence cosmetic GTK warnings:
90397eaba— "gui: pin a minimum height on preferences wxSlider widgets" (which had aimed to silence theNegative content height -15 (allocation 9, extents 12x12)warning from amulegui: gtk assertions #815 by changing every preferences slider's constructor fromwxSize(100, -1)towxSize(100, 24)).cece74ba2— "drop wxFlexGridSizer on the Advanced prefs tab to silence GTK warnings" (PR fix(amule-gui): drop wxFlexGridSizer on the Advanced prefs tab to silence GTK warnings #833, which had aimed to silence the secondary warnings introduced by the change in amuleweb cookies read behind a "lowercase" proxy (http/2 compliant) #1 by swapping the Advanced tab's root sizer).Why
Verified on a clean Ubuntu ARM64 VM (wxGTK 3.2.9, GTK 3, Adwaita-dark):
90397eaba(a9481080e, 245 commits back)90397eaba(wxSize(100,24))cece74ba2(#833, sizer swap)3440f8b28(this PR's previous SetMinSize attempt)The original
Negative content height -15warning from #815 was a transient GTK CSS-gadget warning during cursor-leave re-layout passes — cosmetic, didn't affect rendering, exactly as Stoatwblr characterised it ("can wait"). My #815 fix (thewxSize(100, 24)floor in90397eaba) tried to silence it by giving GTK a 24 px height floor, but on wxGTK 3.2.9 that floor breaks the slider's intrinsic rendering path — the slider goes invisible AND a different trough warning starts firing on every re-layout pass. #833 was a follow-up trying to suppress that new warning, and #836's previous SetMinSize commit was a further follow-up trying to suppress the leftover trough warning — neither addressed the actual cause, which is that thewxSize(100, 24)floor itself is the regression source.Reverting both restores the pre-#815-fix behaviour: sliders render at their wxGTK-natural height (no warnings, no invisibility). The cosmetic
-15warning from the original #815 report stays accepted as known cosmetic noise.Refs
Closes #832 (caused by the regression being reverted here)
Re-resolves #815 — accept the cosmetic transient warning rather than chase it with a worse fix