fix(amuleweb): change --upnp-port from switch to numeric option - #820

…ject#820)

WITH_LIBAYATANA_APPINDICATOR is flipped on by a pkg_check_modules probe for
ayatana-appindicator3-0.1, so whether the SNI tray backend compiles depends
on whether that dev package happens to be installed. It was in no workflow's
cmake_ubuntu_deps, so the appindicator half of the tray code -- the backend
used on Linux desktops -- was #ifdef'd out on every pre-merge job.

packaging.yml does build it, via the AppImage Dockerfile and the Flatpak
manifest, but that workflow fires on push to master rather than on open PRs.
So a break in that half passed every check on the PR and was first compiled
once it had already landed.

ccpp.yml, clang-tidy.yml and codeql.yml each carry their own dep list, so all
three needed it: one to compile the code, the others to lint and analyse it.

Tier-1 clang-tidy is a zero-warnings-under-src gate, so making previously
invisible code visible could have turned it red on pre-existing findings. It
does not: all four files referencing the option -- MuleTrayIcon.cpp,
MuleTrayIcon.h, amule.cpp and amuleDlg.cpp -- report zero Tier-1 findings
with the backend enabled. Each zero was control-checked with
readability-magic-numbers (124/136/162 warnings) to confirm the translation
units were really analysed rather than skipped.

Confirmed in this PR's own CI: both Ubuntu jobs report "AppIndicator3 found:
ayatana-appindicator3-0.1 0.5.90 — tray icon uses SNI backend".