Skip to content

Add pt_BR translations to 4 desktop files - #812

Merged
mrjimenez merged 1 commit into
amule-project:masterfrom
cardpuncher:master
Jun 2, 2026
Merged

Add pt_BR translations to 4 desktop files#812
mrjimenez merged 1 commit into
amule-project:masterfrom
cardpuncher:master

Conversation

@cardpuncher

Copy link
Copy Markdown
Contributor

Thank you @mrjimenez for the translations :) I took the liberty to change the Categories=Network;P2P; lines to Categories=Network;FileTransfer; as the latter exists on Fedora's KDE Discover (where you can find other P2P programs) and not the former. Finally, wxcas.desktop and alc.desktop do not use the reverse DNS notation for the file names contrarily to org.amule.aMule.desktop and org.amule.aMule.gui.desktop. @got3nks Is that okay?

@got3nks

got3nks commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Thanks for picking these up, and for catching the Categories mismatch.

On Categories: both FileTransfer and P2P are valid freedesktop additional categories under Networkthe spec lists FileTransfer as "Tools like FTP or P2P programs" and P2P as "A P2P program". Nothing stops a .desktop file from listing both. Could we go with Categories=Network;FileTransfer;P2P; instead of swapping? That gets us into Discover via FileTransfer while keeping the more specific P2P tag for anything that filters on it. Happy with FileTransfer alone if you'd rather keep the diff minimal — your call.

On the reverse-DNS naming: the two main files use org.amule.aMule.* because they're bound to org.amule.aMule.metainfo.xml AppStream metadata, and the desktop-entry ID has to match the metainfo component ID for Flatpak/Discover to associate them. wxcas.desktop and alc.desktop don't have their own metainfo files — they're utility binaries packaged alongside aMule, not standalone Flatpak/Snap components — so the plain names are fine. Renaming them would also need packaging changes across every distro's spec file + icon paths, so let's leave that for a separate PR if/when we decide to ship them as independent components.

@mrjimenez
mrjimenez merged commit abd2e3f into amule-project:master Jun 2, 2026
7 checks passed
got3nks added a commit to got3nks/amule that referenced this pull request Jun 4, 2026
…ndex

Adds 55+ merged PRs to the 3.0.0 changelog since the last update
(amule-project#747, 2026-05-27). Narrative additions cover:

- Packaging: expanded the top list to include the macOS per-arch .app
  bundles and the Windows NSIS installer alongside the existing
  AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785
  (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg
  amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796
  (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths).

- Bug Fixes & Stability: post-amule-project#744 fixes including EC notification
  leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728),
  amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760),
  PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788,
  amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756),
  Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833,
  amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774).

- Translations: late-cycle wave covering French/Turkish manpages
  (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR
  (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for
  date+version drift (amule-project#802).

- Contributors: added ngosang for UX feedback on the late-3.0
  cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the
  user-facing manual at amule-org.github.io.

- Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.
got3nks added a commit to got3nks/amule that referenced this pull request Jun 4, 2026
…ndex

Adds 55+ merged PRs to the 3.0.0 changelog since the last update
(amule-project#747, 2026-05-27). Narrative additions cover:

- Packaging: expanded the top list to include the macOS per-arch .app
  bundles and the Windows NSIS installer alongside the existing
  AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785
  (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg
  amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796
  (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths).

- Bug Fixes & Stability: post-amule-project#744 fixes including EC notification
  leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728),
  amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760),
  PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788,
  amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756),
  Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833,
  amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774).

- Translations: late-cycle wave covering French/Turkish manpages
  (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR
  (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for
  date+version drift (amule-project#802).

- Contributors: added ngosang for UX feedback on the late-3.0
  cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the
  user-facing manual at amule-org.github.io.

- Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.
mrjimenez pushed a commit that referenced this pull request Jun 4, 2026
Adds 55+ merged PRs to the 3.0.0 changelog since the last update
(#747, 2026-05-27). Narrative additions cover:

- Packaging: expanded the top list to include the macOS per-arch .app
  bundles and the Windows NSIS installer alongside the existing
  AppImage / Flatpak / .dmg / .zip entries. New bullets for #785
  (alc/alcc/cas/wxcas everywhere + Windows amuleweb), #794 (.dmg
  amuleweb path), #789 (<OS>-<arch> artifact naming), #780 / #796
  (Windows DPI + comctl32 manifest), #784 (FHS share/amule paths).

- Bug Fixes & Stability: post-#744 fixes including EC notification
  leak (#797), big-library scaling (#736, #840 superseding #728),
  amulegui ghost entries (#810, #819, #841, #824, #830, #760),
  PartFile early hash (#762), server protocol fixes (#835, #788,
  #721, #787), crypto stream UB (#779), UAF prevention (#756),
  Kad rotation (#795, #799/#805), GTK warning silencing (#833,
  #826/#836), and the clang-tidy worklist (#770, #772-#774).

- Translations: late-cycle wave covering French/Turkish manpages
  (#753/#754/#776), Galician (#763), Slovenian (#771), pt-BR
  (#768/#775/#812), French (#811), plus man-page tooling for
  date+version drift (#802).

- Contributors: added ngosang for UX feedback on the late-3.0
  cycle (#817/#818/#821/#828/#844) and ongoing work on the
  user-facing manual at amule-org.github.io.

- Merged PRs flat index: extended with #746-#845 + #841.
mrjimenez pushed a commit to mrjimenez/amule that referenced this pull request Aug 8, 2026
…ject#812)

CMuleDataViewCtrl::LoadColumnSettings() cleared m_sort_orders and replayed
whatever LoadSettings() decoded. On a profile with no saved TableOrdering for
the list, LoadSettings() reads "", takes the old-style path, and its tokenizer
yields nothing -- so the clear stood and the chain was left empty.

CServerListCtrl::Init() installs ApplySorting(COLUMN_SERVER_NAME, 0) to
prevent exactly that, but SetTableName("Server") runs before
LoadColumnSettings(), so the HasTableName() early return did not protect it
and the default was wiped.

An empty chain makes CompareItemsFull() answer 0 for every pair, and
InsertPos()'s lower_bound then answers begin(): every AddItemData() landed at
row 0, so the server list filled in reverse arrival order, unsorted, with no
header caret. CServerListCtrl has a single add path (RefreshServer ->
AddItemData), so the initial server.met load went the same way.
CSearchListCtrl installs no default at all and was left unsorted too.

Only reachable without saved column settings, which is why an interactive
pass on a developer profile never showed it.

Clear only when the config actually decoded something, so a list's own
default survives, and keep CMuleListCtrl::LoadSettings()'s old guarantee of
at least one entry for lists that install no default. Separately, InsertPos()
now appends when the chain is empty, as CMuleListCtrl::GetInsertPos() does --
without that an unsorted list fills backwards rather than in arrival order.

Verified on an instrumented build: with the saved sort stripped the chain went
0 -> 1 and insert positions 0,0,0,0,0,0 -> 0,0,1,3,2,2, while the
saved-settings path was byte-identical before and after.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants