fix: amulegui ghost entries when EC alive-marker arrives for unknown ID - #810

…ng metadata was suppressed (#808 follow-up)

#810 plugged the first variant of the #808 ghost-entry pattern --
an EC_TAG_KNOWNFILE alive-marker tag with no children arriving for
a file ID amulegui has no record of.

A second variant with identical symptoms remains.
CEC_SharedFile_Tag (ECSpecialCoreTags.cpp:221) runs each metadata
field through a per-connection CValueMap (ECSpecialTags.h:59),
which suppresses tags whose value hasn't changed since the last
cached send. On EC_DETAIL_INC_UPDATE for a file ID amulegui hasn't
seen yet, the server may already have cached + suppressed
EC_TAG_PARTFILE_HASH / _NAME / _SIZE_FULL -- so the tag still
carries plenty of statistical children (request count, accept
count, transferred bytes, AICH masterhash, priority...) and the
HasChildTags() guard added in #810 lets it through, but
CKnownFile(tag) then reads empty hash + empty name + zero size via
GetTagByNameSafe and produces the same "0-byte unnamed" ghost
entry Stoatwblr reported.

Defensive check on the new-item path in CKnownFilesRem::Process
Update: if the tag is missing EC_TAG_PARTFILE_HASH (the canonical
identity tag), log on logEC and skip. The next full-state poll or
the existing entry-mismatch recovery path picks the file up
correctly once the server-side cache invalidation puts the
identifying metadata back on the wire.

Triggered in the wild by Stoatwblr's bulk `updatesharedir` /
`reload shared` script: amuled adds files to its shareset, the
INC_UPDATE diff to amulegui includes them as new entries, but
the per-(connection, ECID) value-map cache may already have
suppressed the identity fields, so the ghost entry pattern fires
once per affected file.

Refs #808 (#810 covered the alive-marker variant of the same bug).

…ndex

Adds 55+ merged PRs to the 3.0.0 changelog since the last update
(amule-project#747, 2026-05-27). Narrative additions cover:

- Packaging: expanded the top list to include the macOS per-arch .app
  bundles and the Windows NSIS installer alongside the existing
  AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785
  (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg
  amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796
  (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths).

- Bug Fixes & Stability: post-amule-project#744 fixes including EC notification
  leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728),
  amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760),
  PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788,
  amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756),
  Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833,
  amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774).

- Translations: late-cycle wave covering French/Turkish manpages
  (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR
  (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for
  date+version drift (amule-project#802).

- Contributors: added ngosang for UX feedback on the late-3.0
  cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the
  user-facing manual at amule-org.github.io.

- Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.

…ndex

Adds 55+ merged PRs to the 3.0.0 changelog since the last update
(amule-project#747, 2026-05-27). Narrative additions cover:

- Packaging: expanded the top list to include the macOS per-arch .app
  bundles and the Windows NSIS installer alongside the existing
  AppImage / Flatpak / .dmg / .zip entries. New bullets for amule-project#785
  (alc/alcc/cas/wxcas everywhere + Windows amuleweb), amule-project#794 (.dmg
  amuleweb path), amule-project#789 (<OS>-<arch> artifact naming), amule-project#780 / amule-project#796
  (Windows DPI + comctl32 manifest), amule-project#784 (FHS share/amule paths).

- Bug Fixes & Stability: post-amule-project#744 fixes including EC notification
  leak (amule-project#797), big-library scaling (amule-project#736, amule-project#840 superseding amule-project#728),
  amulegui ghost entries (amule-project#810, amule-project#819, amule-project#841, amule-project#824, amule-project#830, amule-project#760),
  PartFile early hash (amule-project#762), server protocol fixes (amule-project#835, amule-project#788,
  amule-project#721, amule-project#787), crypto stream UB (amule-project#779), UAF prevention (amule-project#756),
  Kad rotation (amule-project#795, amule-project#799/amule-project#805), GTK warning silencing (amule-project#833,
  amule-project#826/amule-project#836), and the clang-tidy worklist (amule-project#770, amule-project#772-amule-project#774).

- Translations: late-cycle wave covering French/Turkish manpages
  (amule-project#753/amule-project#754/amule-project#776), Galician (amule-project#763), Slovenian (amule-project#771), pt-BR
  (amule-project#768/amule-project#775/amule-project#812), French (amule-project#811), plus man-page tooling for
  date+version drift (amule-project#802).

- Contributors: added ngosang for UX feedback on the late-3.0
  cycle (amule-project#817/amule-project#818/amule-project#821/amule-project#828/amule-project#844) and ongoing work on the
  user-facing manual at amule-org.github.io.

- Merged PRs flat index: extended with amule-project#746-amule-project#845 + amule-project#841.

Adds 55+ merged PRs to the 3.0.0 changelog since the last update
(#747, 2026-05-27). Narrative additions cover:

- Packaging: expanded the top list to include the macOS per-arch .app
  bundles and the Windows NSIS installer alongside the existing
  AppImage / Flatpak / .dmg / .zip entries. New bullets for #785
  (alc/alcc/cas/wxcas everywhere + Windows amuleweb), #794 (.dmg
  amuleweb path), #789 (<OS>-<arch> artifact naming), #780 / #796
  (Windows DPI + comctl32 manifest), #784 (FHS share/amule paths).

- Bug Fixes & Stability: post-#744 fixes including EC notification
  leak (#797), big-library scaling (#736, #840 superseding #728),
  amulegui ghost entries (#810, #819, #841, #824, #830, #760),
  PartFile early hash (#762), server protocol fixes (#835, #788,
  #721, #787), crypto stream UB (#779), UAF prevention (#756),
  Kad rotation (#795, #799/#805), GTK warning silencing (#833,
  #826/#836), and the clang-tidy worklist (#770, #772-#774).

- Translations: late-cycle wave covering French/Turkish manpages
  (#753/#754/#776), Galician (#763), Slovenian (#771), pt-BR
  (#768/#775/#812), French (#811), plus man-page tooling for
  date+version drift (#802).

- Contributors: added ngosang for UX feedback on the late-3.0
  cycle (#817/#818/#821/#828/#844) and ongoing work on the
  user-facing manual at amule-org.github.io.

- Merged PRs flat index: extended with #746-#845 + #841.

…_FILES / GET_DLOAD_QUEUE

The EC skip-unchanged opt-in (93a0676 "EC skip-unchanged (4/5)")
gates the per-file emit on `m_ecGen <= ec_threshold` in three
handlers. For unchanged files the server either emits a childless
alive-marker tag (legacy clients) or skips silently (partial-update
clients). Both shortcuts assume the client has previously received
the ECID with full detail. If it hasn't, the alive marker
constructs a ghost CKnownFile from an empty tag (amule-project#810 surface) and
the silent skip leaves the file invisible. The CValueMap-driven
identity suppression on subsequent emissions extends the surface to
INC_UPDATE tags that have children but no identifying fields (amule-project#819
surface).

The amulegui-side guards in amule-project#810 and amule-project#819 cover that client
specifically. Other legacy EC consumers — amuleweb, amulecmd, and
third-party clients — have no analogous guard and silently lose
newly-shared files until restart.

Fix at the source: track per-connection, per-handler ECIDs that
have been sent with full detail. Gate the alive-marker / silent-
skip shortcut on membership in that set. Files the client hasn't
seen fall through to full-detail emission unconditionally, and the
emission populates the per-connection CObjTagMap (so subsequent
INC_UPDATE diffs work) and inserts into the new sent-with-detail
set.

Three handlers, three sets — one per request path because each
handler has its own `m_lastEcGenSeen*` cadence.

Memory cost: bounded by alive-file ECID count per connection
(~360 KB at 91k files; insignificant). Never pruned — re-share
bumps m_ecGen via SetFilePath / Init so any resurrected ECID
naturally takes the full-detail branch again.

The amulegui guards from amule-project#810 and amule-project#819 stay as defensive belt-and-
suspenders for amulegui talking to unpatched / older daemons.

…_FILES / GET_DLOAD_QUEUE

The EC skip-unchanged opt-in (93a0676 "EC skip-unchanged (4/5)")
gates the per-file emit on `m_ecGen <= ec_threshold` in three
handlers. For unchanged files the server either emits a childless
alive-marker tag (legacy clients) or skips silently (partial-update
clients). Both shortcuts assume the client has previously received
the ECID with full detail. If it hasn't, the alive marker
constructs a ghost CKnownFile from an empty tag (amule-project#810 surface) and
the silent skip leaves the file invisible. The CValueMap-driven
identity suppression on subsequent emissions extends the surface to
INC_UPDATE tags that have children but no identifying fields (amule-project#819
surface).

The amulegui-side guards in amule-project#810 and amule-project#819 cover that client
specifically. Other legacy EC consumers — amuleweb, amulecmd, and
third-party clients — have no analogous guard and silently lose
newly-shared files until restart.

Fix at the source: track per-connection, per-handler ECIDs that
have been sent with full detail. Gate the alive-marker / silent-
skip shortcut on membership in that set. Files the client hasn't
seen fall through to full-detail emission unconditionally, and the
emission populates the per-connection CObjTagMap (so subsequent
INC_UPDATE diffs work) and inserts into the new sent-with-detail
set.

Three handlers, three sets — one per request path because each
handler has its own `m_lastEcGenSeen*` cadence.

Memory cost: bounded by alive-file ECID count per connection
(~360 KB at 91k files; insignificant). Never pruned — re-share
bumps m_ecGen via SetFilePath / Init so any resurrected ECID
naturally takes the full-detail branch again.

The amulegui guards from amule-project#810 and amule-project#819 stay as defensive belt-and-
suspenders for amulegui talking to unpatched / older daemons.

…_FILES / GET_DLOAD_QUEUE

The EC skip-unchanged opt-in (93a0676 "EC skip-unchanged (4/5)")
gates the per-file emit on `m_ecGen <= ec_threshold` in three
handlers. For unchanged files the server either emits a childless
alive-marker tag (legacy clients) or skips silently (partial-update
clients). Both shortcuts assume the client has previously received
the ECID with full detail. If it hasn't, the alive marker
constructs a ghost CKnownFile from an empty tag (#810 surface) and
the silent skip leaves the file invisible. The CValueMap-driven
identity suppression on subsequent emissions extends the surface to
INC_UPDATE tags that have children but no identifying fields (#819
surface).

The amulegui-side guards in #810 and #819 cover that client
specifically. Other legacy EC consumers — amuleweb, amulecmd, and
third-party clients — have no analogous guard and silently lose
newly-shared files until restart.

Fix at the source: track per-connection, per-handler ECIDs that
have been sent with full detail. Gate the alive-marker / silent-
skip shortcut on membership in that set. Files the client hasn't
seen fall through to full-detail emission unconditionally, and the
emission populates the per-connection CObjTagMap (so subsequent
INC_UPDATE diffs work) and inserts into the new sent-with-detail
set.

Three handlers, three sets — one per request path because each
handler has its own `m_lastEcGenSeen*` cadence.

Memory cost: bounded by alive-file ECID count per connection
(~360 KB at 91k files; insignificant). Never pruned — re-share
bumps m_ecGen via SetFilePath / Init so any resurrected ECID
naturally takes the full-detail branch again.

The amulegui guards from #810 and #819 stay as defensive belt-and-
suspenders for amulegui talking to unpatched / older daemons.