docs: migrate wiki references to amule-org.github.io/docs - #801

Addresses @ngosang review feedback on #801: the About dialog had
"FAQ: https://amule-org.github.io/docs", but the dedicated FAQ page
already lives at /docs/manual/faq (which the README's [FAQ] reference
was migrated to in the same PR). Switch the About dialog string to
match.

The F1 keyboard shortcut keeps pointing at /docs (the docs landing).
sl.po's stale Slovenian "PZS: " translation is hand-updated to match
the new msgid, same approach used for the original URL migration.

Per ngosang's review on #801:

- "FAQ:" -> "Documentation:" pointing at the docs landing page
  (https://amule-org.github.io/docs) rather than the FAQ subpage.
- "Contact: [email protected] (administrative issues)" replaced with
  "Issues: https://github.com/amule-org/amule/issues" -- the admin@
  mailbox is currently unreachable; the GitHub issue tracker is the
  live channel for both administrative and bug reports.
- Copyright year bumped 2003-2019 -> 2003-2026 for the 3.0.0 release.

Captures translatable strings introduced after the previous po
refresh (post-amule-project#747 wave). Notable new entries:

  - "Connection failed. Please check the host, port, and password."
    (amule-project#841 — amulegui retry-on-connect-failure)
  - "Force ZLIB compression" (amule-project#840 — EC client-tag locality override)
  - "Follow symbolic links in shared folders" (amule-project#809)
  - "Connection Type:" (amule-project#824 — ED2K Info readability)
  - "Documentation: https://amule-org.github.io/docs " (amule-project#801 — wiki
    URL migration)

Generated with `scripts/update-po.sh` from a working tree that has
PR amule-project#841 applied locally, so the new amulegui retry-loop strings
are included even though amule-project#841 itself is not in this branch — when
amule-project#841 lands on master, the .po files will already reflect its
strings without needing a second regeneration pass.

The remaining churn is line-number realignment across the ~38
language files from a month of source-code drift.

Captures translatable strings introduced after the previous po
refresh (post-amule-project#747 wave). Notable new entries:

  - "Connection failed. Please check the host, port, and password."
    (amule-project#841 — amulegui retry-on-connect-failure)
  - "Force ZLIB compression" (amule-project#840 — EC client-tag locality override)
  - "Follow symbolic links in shared folders" (amule-project#809)
  - "Connection Type:" (amule-project#824 — ED2K Info readability)
  - "Documentation: https://amule-org.github.io/docs " (amule-project#801 — wiki
    URL migration)

Generated with `scripts/update-po.sh` from a working tree that has
PR amule-project#841 applied locally, so the new amulegui retry-loop strings
are included even though amule-project#841 itself is not in this branch — when
amule-project#841 lands on master, the .po files will already reflect its
strings without needing a second regeneration pass.

The remaining churn is line-number realignment across the ~38
language files from a month of source-code drift.

Captures translatable strings introduced after the previous po
refresh (post-#747 wave). Notable new entries:

  - "Connection failed. Please check the host, port, and password."
    (#841 — amulegui retry-on-connect-failure)
  - "Force ZLIB compression" (#840 — EC client-tag locality override)
  - "Follow symbolic links in shared folders" (#809)
  - "Connection Type:" (#824 — ED2K Info readability)
  - "Documentation: https://amule-org.github.io/docs " (#801 — wiki
    URL migration)

Generated with `scripts/update-po.sh` from a working tree that has
PR #841 applied locally, so the new amulegui retry-loop strings
are included even though #841 itself is not in this branch — when
#841 lands on master, the .po files will already reflect its
strings without needing a second regeneration pass.

The remaining churn is line-number realignment across the ~38
language files from a month of source-code drift.

…e-project#180, amule-project#801) (amule-project#839)

* feat(gui): port CFileDetailListCtrl to CMuleVirtualDataViewCtrl (amule-project#180, amule-project#801)

Continues the wxListCtrl -> wxDataViewCtrl migration (amule-project#180/amule-project#801) onto
the shared base from amule-project#811, after Search (amule-project#796), Servers (amule-project#807/amule-project#811)
and Friends (amule-project#830). CFileDetailListCtrl was next because it has no
CBarShader rendering (unlike Downloads/SharedFiles/Sources-Peers,
which additionally need a still-nonexistent wxDataViewCustomRenderer).

Its caller, CFileDetailDialog::FillSourcenameList(), drove the old
list with raw position-indexed CRUD (FindItem by name, SetItemPtrData,
SetItem by column index, DeleteItem) rather than the pointer-identity
style CServerListCtrl/CFriendListCtrl already use, so porting the
control cleanly meant refactoring the caller too:

- CFileDetailDialog gained a std::map<wxString, SourcenameItem *>
  m_sourcenames member, replacing "search the list widget by name"
  with a map lookup. FillSourcenameList()'s reset/update/prune shape
  is otherwise unchanged, just re-keyed to the map and driven through
  the control's new AddSource/RefreshSource/RemoveSource API.
- OnBnClickedTakeOver()/OnListClickedTakeOver() resolve the selected
  row through GetSelectedItemData() (inherited from
  CMuleVirtualDataViewCtrl) instead of GetNextItem+GetItemText.
- The dialog's EVT_LIST_ITEM_ACTIVATED binding on IDC_LISTCTRLFILENAMES
  becomes EVT_DATAVIEW_ITEM_ACTIVATED; wxDataViewEvent is a
  wxNotifyEvent/wxCommandEvent descendant so it still propagates from
  the child control to the dialog-level handler the same way.
- Fixed a latent leak: nothing in ~CFileDetailDialog() freed the
  SourcenameItem objects still referenced by open rows -- only the
  "not a partfile" and "pruned to zero" paths in FillSourcenameList()
  ever deleted them. Now freed in the destructor via m_sourcenames.

CMuleDataViewCtrl always ORs in wxDV_MULTIPLE (no single-selection
mode exists on the shared base), but this list's "take over filename"
actions assume exactly one selection, same as the old list did (it
never actually requested wxLC_SINGLE_SEL either -- checked
muuli_wdr.cpp -- it enforced single-selection itself via OnSelect()
deselecting every other row). CFileDetailListCtrl::OnSelectionChanged()
does the equivalent: collapses to the just-clicked row whenever more
than one ends up selected.

Also deleted a vestigial nested SourcenameItem struct in
FileDetailListCtrl.h that duplicated (by accident of matching layout)
the real one in PartFile.h, and dropped a per-row background-colour
set that reproduced the default and carried its own "do we still need
this?" comment.

Verified: builds clean; clang-format v18 (pinned Docker image) applied;
clang-tidy Tier-1 (whole-tree) and Tier-2 (changed-lines,
.clang-tidy-new-code) both clean via the ~/aMuleTest/ci-local replica.
Grepped for other CFileDetailListCtrl/IDC_LISTCTRLFILENAMES references
to confirm muuli_wdr.cpp's construction call needed no changes.
Interactive verification (source list populate/re-tally, take-over via
button and double-click, single-selection enforcement, sort, VoiceOver)
left for manual testing per project convention.

* fix(gui): keep the source-name list sorted, and drop rows before freeing them

Review follow-up to the port.

FillSourcenameList() zeroes every count and then rewrites them in place, so
while it runs the list is not ordered by the column it is sorted on -- and
AddSource() places a new row with a binary search, which needs that ordering
to hold. An insertion therefore leaves rows in arbitrary positions, and the
repair has to happen here, exactly as the pre-port code did.

Only on insertion, though. A count that merely changed is what the live-sort
preference governs: RefreshSource() re-sorts when it is on, and when it is
off the row is meant to stay put rather than move under the user. Sorting
unconditionally would quietly override that setting for this list.

The destructor and the not-a-partfile path also freed the SourcenameItem
objects while the list control still held pointers to them. Nothing can
paint or sort in either window today -- both dialog call sites are stack
temporaries, so destruction is synchronous -- but that rests on wx's teardown
order rather than on anything guaranteed, and the base states the rule
plainly: it has to be told before the caller frees the item data. Both now
clear the rows first, as the prune loop already did.

* fix(gui): decide the source list's live re-sort per column

IsLiveSortColumn() answered true for every column, so a refresh tick
scheduled a re-sort even when the list was sorted by File Name -- a value
that never changes, since the name is the key each row was created under.

Answer per column instead, the shape CServerListCtrl already uses, so only a
sources-sorted list re-sorts on its own. The header comment already
described it this way; only the implementation did not.

* chore: drop a duplicated paragraph from the file header

FileDetailDialog.cpp carried the "Any parts of this program derived from
the xMule, lMule or eMule project" paragraph twice. It is the only file in
src/ that does, and the file is already being touched here.

---------

Co-authored-by: got3nks <[email protected]>

amule-project#796 ported the search list to wxDataViewCtrl and amule-project#805 fixed what that
port left behind. amule-project#801 asked whether the remaining lists should each be
ported independently or share a base, and deferred the answer until the
shape was clear from more than one list. It now is.

CMuleDataViewCtrl is the wxDataViewCtrl counterpart of CMuleListCtrl:
column widths and their persistence, the header show/hide menu, hidden
state, the multi-column sort chain, type-to-select, Cmd/Ctrl+A, the
macOS shifted page/home/end keys, the trailing-column spacer, and
drag-resize detection. It owns no data; a list supplies its rows through
GetDisplayOrder(), their label through GetRowLabel(), and how two of
them compare through CompareByColumn().

CMuleVirtualDataViewCtrl is the counterpart of CMuleVirtualListCtrl,
and virtual in the same sense: rows are addressed by index through a
wxDataViewIndexListModel and nothing is materialised per row. It carries
the item-identity bookkeeping an identity-addressed port avoids -- a
wxDataViewItem from a row-addressed model encodes the row number, so a
deletion silently retargets any item held across it, which is why
everything here speaks in wxUIntPtr and re-resolves selection after each
mutation. Also the legacy filter API, live re-sort coalesced through one
CallAfter and deferred while the user is interacting, bulk append and
batch removal, and icon columns.

CSearchListCtrl moves onto the plain base, losing 499 lines.

…mule-project#801)

The first list onto CMuleVirtualDataViewCtrl, and what makes it more
than dead code. Supersedes the port in amule-project#807, whose approach and column
handling informed this one.

The list keeps its public API, so ServerWnd, GuiEvents and the remote
GUI are unchanged, and AddServer/RemoveServer/RefreshServer/
HighlightServer work as they did because the base offers the same
AddItemData/RemoveItemData/RefreshItemData vocabulary CMuleVirtualList-
Ctrl did. What is left here is the list's own business: cell text,
country flags, the bold connected server, the comparator, the context
menu and column auto-fit.

Removals notify the control before the core frees the server, rather
than deferring to idle: the row's identity is the object, so anything
touching the list in between -- a repaint, a resort, a menu handler
reading the selection -- would be reading freed memory.

Ping, Users and Files still drive the live re-sort, gated by
thePrefs::LiveListSort() as before; the TCP/UDP flag columns are still
hidden by default in release builds, now through the header menu's
hidden state rather than a zero width.

feat(gui): shared wxDataViewCtrl base, and port CServerListCtrl onto it (amule-project#180, amule-project#801)

…oject#180, amule-project#801) (amule-project#830)

* feat(gui): port CFriendListCtrl to CMuleVirtualDataViewCtrl (amule-project#180, amule-project#801)

Continues the wxListCtrl -> wxDataViewCtrl migration (amule-project#180/amule-project#801) onto
the shared base PR amule-project#811 extracted after the Servers port (amule-project#807, now
absorbed into amule-project#811). CFriendListCtrl was picked next after reading all
the remaining candidates directly rather than going by line count
alone: it has no CBarShader rendering (unlike Downloads/SharedFiles/
Sources-Peers, which additionally need a still-nonexistent
wxDataViewCustomRenderer), it's already pointer-identity addressed
(UpdateFriend(CFriend*)/RemoveFriend(CFriend*) map directly onto
AddItemData/RefreshItemData/RemoveItemData), and its blast radius is
tiny (ChatWnd.cpp, muuli_wdr.cpp construction only).

CFileDetailListCtrl looked smaller by line count but its caller
(FileDetailDialog.cpp) drives it with raw position-indexed CRUD
(FindItem by name, SetItem by column index, DeleteItem) plus a
pre-existing duplicate-type quirk (two unrelated SourcenameItem
structs relying on compatible layout) -- porting it cleanly means
refactoring the caller too, which is a separate, more invasive piece
of work than this one.

CServerListCtrl (current, post-amule-project#811) is the template mirrored here:
same AppendTextColumn/AppendSpacerColumn/AssociateVirtualModel/
LoadColumnSettings/InitColumnState ctor sequence, same GetItemColumnText/
GetItemAttr/CompareItemData/OnListKey hook shape. Public API
(UpdateFriend, RemoveFriend) and the constructor signature are
unchanged, so ChatWnd.cpp and muuli_wdr.cpp needed no edits.

Notable deltas from the pre-port behaviour: added a real CompareItemData
so header-click sort now works (the old list never called SetSortFunc
at all); GetItemAttr replaces the old SetItemTextColour call with the
same visible result (blue for linked friends, default text colour
otherwise).

Verified: builds clean; clang-format v18 (pinned Docker image) applied;
clang-tidy Tier-1 (whole-tree) and Tier-2 (changed-lines,
.clang-tidy-new-code) both clean via the ~/aMuleTest/ci-local replica
-- Tier-2 caught one real modernize-use-nullptr hit, fixed. Grepped
ChatWnd.cpp/.h and muuli_wdr.cpp to confirm no other call sites exist.
Interactive verification (sort, right-click menu states, Delete-key
removal, chat-session activation, VoiceOver) left for manual testing
per project convention, same as PR amule-project#796/amule-project#807.

* fix(gui): resolve activated friend through selection, not row-as-pointer

got3nks's review on amule-project#830 found a real crash: OnItemActivated() cast
event.GetItem()'s ID directly to CFriend* on the assumption it was the
item's data pointer, but CMuleVirtualDataViewCtrl's row-addressed
model returns the row index (+1) as that ID -- the "item identity is
not row identity" case MuleVirtualDataViewCtrl.h itself documents.
Every double-click/Enter on a friend dereferenced a bogus pointer.
Fixed by selecting the activated row and resolving it through
GetSelectedItemData(), matching CServerListCtrl::OnItemActivated.

Also from the same review: IsLiveSortColumn() now returns true, since
the name (the only sortable column) can change after a friend is
already listed and the UpdateFriend() comment claimed a re-sort that
the base's default-false hook never actually triggered; and dropped a
no-op static_cast<int>() around a call that already returns int.

Verified: builds clean, clang-format v18 applied, clang-tidy Tier-2
(changed lines, .clang-tidy-new-code) clean via the local CI replica.

* chore: retrigger CI

The previous run hit a GitHub Actions infrastructure outage (job not
acquired by any runner, "Failed to resolve action download info" /
"Service Unavailable" on clang-format, Translation checks, mingw-w64
Debug and clang-tidy Tier-1) unrelated to this branch's code -- every
job that did run passed. No admin rights to rerun the failed jobs
directly, so retriggering with an empty commit instead.

…xDataViewCtrl (amule-project#842)

Adds CMuleBarRenderer, a wxDataViewCustomRenderer that draws a CBarShader chunk bar, and ports CSharedFilesCtrl from the owner-drawn wxListCtrl to wxDataViewCtrl (amule-project#180, amule-project#801).

Follow-up work on top of the port:

- the bar renderer now sizes to its column: GetSize() returned a constant width, which the generic backend ignores but the native macOS backend takes as the cell size
- the four dataview-ported lists no longer pass wxLC_REPORT|wxSUNKEN_BORDER, left over from their wxListCtrl days; wxLC_REPORT shares its bit with wxDV_VARIABLE_LINE_HEIGHT, so it had been silently enabling that
- the rating/comment smiley moves to its own sortable Rating column, so File Name no longer needs an icon renderer that indents every row without a smiley; default widths revised alongside

Continues the wxListCtrl -> wxDataViewCtrl migration (amule-project#180, amule-project#801), porting CDownloadListCtrl onto the CMuleBarRenderer bridge from amule-project#842.

The Progress cell is composite rather than a plain chunk bar, so CDownloadBarRenderer draws the base bar and adds the completed-progress strip and percentage on top; CBarFillSpec carries the row's item-data pointer so a renderer subclass can reach its own domain type. The per-row cached wxBitmap is not carried forward: CBarShader::Draw() costs microseconds at this cell size, and a cache keyed by a raw CPartFile* would collide with a freed-and-reused address.

FileCtrlItem_Struct is gone -- item data is CPartFile* directly, matching CSharedFilesCtrl -- and m_ListItems becomes a plain std::set, having never backed a real hierarchy. muuli_wdr.cpp drops wxLC_REPORT|wxSUNKEN_BORDER for Downloads, matching 71bdb1a for the lists ported earlier.

…ct#850)

Last remaining piece of amule-project#801's wxListCtrl -> wxDataViewCtrl migration: the shared base behind CSourceListCtrl and CSharedFilePeersListCtrl.

ClientCtrlItem_Struct survives rather than being deleted, unlike the previous ports: one client can be a source or peer of more than one file at a time, so row identity is the (client, owner, type) tuple. Its cached wxBitmap fields are dropped, matching the no-cache precedent from the Shared Files and Downloads ports.

Two bar columns, two renderers: CSourceBarRenderer draws the 5-state chunk bar and substitutes a bordered A4AF text badge for those rows, while the peers' availability column needs only the base renderer and ships without SORTABLE, since no comparison exists for it and none did pre-port. The User Name column is a composite icon cluster plus optional country flag plus text, so it goes through CClientNameRenderer, reaching the row via the identity-carrying CBarFillSpec extension point; GetItemColumnText() still answers plain text there, so type-ahead and the accessible row label work off real text rather than the pre-port empty string.

CompareItemData() keeps the original SortProc's type precedence, sorting A4AF sources last regardless of direction, before dispatching per column. muuli_wdr.cpp drops the legacy wxLC_REPORT|wxSUNKEN_BORDER flags for both lists.

…endored wxGenericListCtrl (amule-project#855)

Follow-up to amule-project#801/amule-project#180: with the client-list port done in amule-project#850, CCommentDialogLst was the only remaining instantiator of CMuleListCtrl and CMuleVirtualListCtrl had no derivers left.

CCommentDialogLst drops to a plain wxListCtrl -- a small read-only modal list that does not warrant the CMuleDataViewCtrl treatment -- with click-to-sort reimplemented by hand. amuleDlg's exit-time SaveListControlSettings() widget walk goes too: it existed because CMuleListCtrl only saved lazily from its destructor, which the tray-Exit path could skip, whereas CMuleDataViewCtrl writes column widths and sort orders eagerly on every resize, sort and show/hide, and SaveGUIPrefs() still flushes on every close path.

That leaves CMuleVirtualListCtrl, CMuleListCtrl and the vendored wxGenericListCtrl with no consumers, so all four files are deleted. IsListBackgroundDark() moves to MuleColour.h. CListColumnStore's legacy config-migration path is untouched -- it still reads pre-dataview TableWidths* entries.

One known simplification: the comments dialog loses its header sort-arrow glyph, which plain wxListCtrl does not draw. A follow-up restores it via ShowSortIndicator().