Skip to content

Move license.txt to the root of the project folder - #730

Merged
mrjimenez merged 1 commit into
masterfrom
fix-license
May 27, 2026
Merged

Move license.txt to the root of the project folder#730
mrjimenez merged 1 commit into
masterfrom
fix-license

Conversation

@mrjimenez

Copy link
Copy Markdown
Contributor

GitHub automatically detect the license but the file must be called LICENSE.md and be placed in the root folder.

Fixes #723.

GitHub automatically detect the license but the file must be called
LICENSE.md and be placed in the root folder.

Fixes #723.
@mrjimenez
mrjimenez merged commit 509f624 into master May 27, 2026
14 checks passed
@mrjimenez
mrjimenez deleted the fix-license branch May 27, 2026 13:07
ngosang added a commit to ngosang/amule that referenced this pull request Jul 30, 2026
…oject#466) (amule-project#730)

The Shared Files view only had static counters, so an actively seeded file
looked the same as an idle one. Surface the four fields 5722207 added to
GET /shared (list and detail alike).

Table (shared.js):
  * New columns: "Up speed" (upload_speed_bps) and "Uploading" (uploading),
    both live off the existing SSE shared channel, plus "Last upload" and
    "Shared since" hidden by default -- the timestamps are wide and rarely
    watched, one click away in the column picker.
  * The totals line now sums the upload speed, mirroring the downloads view.

Detail panel (shared-detail.js): the same four values as rows in the
Sharing section, with tooltips. The existing queued-clients row is left
alone so "uploading" and "queued" read as two neighbouring rows.

format.js: fmtTs, until now local to download-detail.js, becomes the
exported formatTimestamp and is reused by both panels. Unknown timestamps
(0 -- never uploaded, or a known.met entry written before the feature)
render as a dash.

i18n: new keys in en.json and es.json.
got3nks pushed a commit to got3nks/amule that referenced this pull request Jul 31, 2026
…r.cpp (amule-project#675) (amule-project#725)

* chore(gui): delete unreachable bitmap functions/entries from muuli_wdr.cpp

First slice of the icon-system cleanup scoped in amule-project#675: remove code with
zero call sites anywhere in the tree, before any wxArtProvider migration
work starts.

- muleToolbar(): whole function unused -- superseded by the main
  wxToolBar setup in amuleDlg.cpp; nothing calls it.
- moreImages(): whole function unused, both of its two icon entries.
- amuleDlgImages(): 21 of 35 index blocks have no caller anywhere
  (0-13, 16, 17, 19, 27, 28, 31, 34). The 14 live ones are untouched --
  10 of those (20-26, 29, 32, 33) are already the fallback path inside
  amuleDlg.cpp's Add_Skin_Icon, which prefers a wxArtProvider/SVG lookup
  first; the other 4 (14, 15, 18, 30) are still called directly.
- amuleSpecial(): 6 of 26 index blocks have no caller (6, 7, 8, 9, 18,
  20) -- checked both direct call sites and the PrefsUnifiedDlg.cpp
  fallback table (pages[].m_imageidx), which uses neither.

convert_xpm in PartFileConvertDlg.cpp was on the same "no literal
grep hits" list initially but is not actually dead -- SetIcon(wxICON
(convert)) reaches it via the wxICON macro's token-pasting
(X##_xpm), invisible to a plain identifier search. Caught by a full
build failing on the undeclared identifier, not by inspection; left
untouched.

Deletes 1373 lines (~16% of the file). No behavior change: every
touched entry was unreachable code. clang-format v18 clean; full
amule build verified (macOS, CLIENT_GUI unaffected since neither
touched symbol is CLIENT_GUI-only).

* chore(po): regenerate catalogs after muuli_wdr.cpp dead-code removal

muleToolbar() duplicated several msgid source-location references
(Networks, Searches, Downloads Window, etc.) already present via
amuleDlg.cpp's own toolbar setup. Deleting it drops those now-stale
#: comments; no msgid added, removed, or retranslated -- verified via
unchanged msgid count (1903 before/after) and a diff limited to
source-location comments and POT-Creation-Date.

Regenerated after rebasing onto upstream/master to pick up po/
changes from amule-project#723/amule-project#724/amule-project#726/amule-project#728/amule-project#730/amule-project#731, which had drifted our
prior regeneration out of sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the license file into the root folder

2 participants