Preferences: upgrade default eMule-security and shortypower URLs to https - #718
Merged
mrjimenez merged 1 commit intoMay 25, 2026
Merged
Conversation
…ttps All three sites now serve the same content over https with valid certs: - KadNodesUrl: http://upd.emule-security.org/nodes.dat -> https - Ed2kServersUrl: http://upd.emule-security.org/server.met -> https - StatsServerURL: http://ed2k.shortypower.dyndns.org/?hash= -> https://ed2k.shortypower.org/?hash= (the dyndns.org host has been retired in favour of the apex domain) Existing user configs are unaffected — these are just the seed values applied when a key is missing from amule.conf. Users who already have the old http URLs persisted in amule.conf or in addresses.dat keep those values until they reset / edit them. Fixes amule-project#714.
ngosang
added a commit
to ngosang/amule
that referenced
this pull request
Jul 30, 2026
amule-project#718) PATCH /api/v0/servers/{ecid} has carried both fields since the API grew it, but the server list never used it: priority was a read-only string cell and the static flag only showed up as a badge tucked inside the name cell, so neither could be changed without the desktop GUI's context menu. Add a Static column right before Priority, visible by default, and turn both cells into selects that show the current value and PATCH on change — the same guest-aware select pattern the downloads and shared tables already use for their priority column, with one patchServer() helper mirroring remove()'s try/catch + toast + data.refresh("servers"). Priority's options are the exact three values ServerPriorityCode() accepts, and its sortVal now returns the rank instead of the raw string, so the column sorts low -> normal -> high rather than alphabetically (high, low, normal). Static sorts on the boolean. Width goes 90px -> 110px so "Normal" fits. The static badge is dropped from the name cell now that the column shows the same thing and can also change it; that retires networks_server_badge_static and its title string, plus the .name-cell .badge CSS rule, in favour of six new networks_server_{prio_low,prio_normal,prio_high,static,static_yes,static_no} strings in both locales. Verified against a live daemon: both selects PATCH 200 and the new values survive a reload, each column sorts both ways, and the Spanish labels render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote the three URL defaults shipped in
Preferences::BuildItemListto https. All three sites now serve identical content over https with valid certs (verified withcurl -sSI).KadNodesUrl:http://upd.emule-security.org/nodes.dat→https://…Ed2kServersUrl:http://upd.emule-security.org/server.met→https://…StatsServerURL:http://ed2k.shortypower.dyndns.org/?hash=→https://ed2k.shortypower.org/?hash=(the dyndns.org host has been retired; the apex domain serves the same hash lookup)Existing user configs are unaffected — these are just the seed values applied when a key is missing from
amule.conf. Users who already have the old http values persisted inamule.conf(or inaddresses.dat, which is a separate manual file consumed byCServerList::AutoUpdate) keep their values until they reset / edit them.Test plan
Content-Type: application/octet-stream(eMule-security) /text/html(shortypower)amule.conf), confirm the seeded URLs are the https variants in the Preferences UIFixes #714.